Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Oct 2021 14:28:30 +0800
From:      Po-Chuan Hsieh <sunpoet@sunpoet.net>
To:        Mateusz Piotrowski <0mp@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: 78ac218c1935 - main - devel/py-resolvelib07: Copy from devel/py-resolvelib07
Message-ID:  <CAMHz58RBHUEbg_9Jcd2-1D97scarTnrZT4bFv2e8mxQcpRcW9Q@mail.gmail.com>
In-Reply-To: <202110121758.19CHw9c3026154@gitrepo.freebsd.org>
References:  <202110121758.19CHw9c3026154@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000280c1605ce36146c
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 13, 2021 at 1:58 AM Mateusz Piotrowski <0mp@freebsd.org> wrote:

> The branch main has been updated by 0mp:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=78ac218c19353689664612d3d3399b9462d2076d
>
> commit 78ac218c19353689664612d3d3399b9462d2076d
> Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
> AuthorDate: 2021-10-12 17:34:24 +0000
> Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
> CommitDate: 2021-10-12 17:58:01 +0000
>
>     devel/py-resolvelib07: Copy from devel/py-resolvelib07
>
>     devel/py-pdm requires py-resolvelib to stay within 0.7 branch.
>
>     Reported by:    olegni@
> ---
>  devel/py-resolvelib07/Makefile  | 22 ++++++++++++++++++++++
>  devel/py-resolvelib07/distinfo  |  3 +++
>  devel/py-resolvelib07/pkg-descr |  5 +++++
>  3 files changed, 30 insertions(+)
>
> diff --git a/devel/py-resolvelib07/Makefile
> b/devel/py-resolvelib07/Makefile
> new file mode 100644
> index 000000000000..25f7024766a7
> --- /dev/null
> +++ b/devel/py-resolvelib07/Makefile
> @@ -0,0 +1,22 @@
> +PORTNAME=      resolvelib
> +DISTVERSION=   0.5.5
> +CATEGORIES=    devel python
> +MASTER_SITES=  CHEESESHOP
> +PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
> +PKGNAMESUFFIX= 05
> +
> +MAINTAINER=    0mp@FreeBSD.org
> +COMMENT=       Resolve abstract dependencies into concrete ones
> +
> +LICENSE=       ISCL
> +
> +USES=          python:3.6+
> +USE_PYTHON=    autoplist concurrent distutils
> +
> +CONFLICTS_INSTALL=     py${PYTHON_SUFFIX}-${PORTNAME}
>

Hi,

It would be better to use ${PYTHON_PKGNAMEPREFIX} instead of
py${PYTHON_SUFFIX}.
It matches the literal meaning and is consistent with
"PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}" in py-* ports.

Regards,
sunpoet

--000000000000280c1605ce36146c--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58RBHUEbg_9Jcd2-1D97scarTnrZT4bFv2e8mxQcpRcW9Q>