From owner-cvs-all Sat Feb 23 20:55:35 2002 Delivered-To: cvs-all@freebsd.org Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by hub.freebsd.org (Postfix) with ESMTP id 657BC37B402; Sat, 23 Feb 2002 20:55:31 -0800 (PST) Received: from scsiguy.com (localhost [127.0.0.1]) by aslan.scsiguy.com (8.11.6/8.11.5) with ESMTP id g1O4u1I73942; Sat, 23 Feb 2002 21:56:02 -0700 (MST) (envelope-from gibbs@scsiguy.com) Message-Id: <200202240456.g1O4u1I73942@aslan.scsiguy.com> To: Warner Losh Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ep if_ep.c In-Reply-To: Your message of "Mon, 11 Feb 2002 21:32:59 PST." <200202120532.g1C5WxT89815@freefall.freebsd.org> Date: Sat, 23 Feb 2002 21:56:01 -0700 From: "Justin T. Gibbs" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >imp 2002/02/11 21:32:59 PST > > Modified files: > sys/dev/ep if_ep.c > Log: > Two fixes from Jonathan Hanna: > 1) We shouldn't continue when we get a RX complete because we ack it > and the TX complete. > 2) Fix a couple of spl leaks > (why splbio is needed in ISR, I cannot understand). It's a hack to prevent a PIO IDE transfer from cutting into the ep driver's PIO packet processing. Remember that these cards have a paultry 2K of buffer space, so overruns were common during heaving ATA activity in the "good old days" of ATA without DMA. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message