Date: Fri, 12 Jun 2020 18:32:30 +0200 From: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> To: freebsd-hackers@freebsd.org Subject: Re: maintaining CRYPTO_TIMING Message-ID: <20200612163230.37ocjvfebolkqiws@nerd-thinkpad.local> In-Reply-To: <20200612161401.GA3992@raichu> References: <20200612161401.GA3992@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
--fsh3nvpqkl5age7d Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Fri, Jun 12, 2020 at 12:14:01PM -0400, Mark Johnston wrote: >Hi, > >I noticed that the opencrypto framework maintains counters for various >operations. These counters are all global and are updated >non-atomically, so they aren't SMP-friendly and won't be precise. I >wrote a patch to convert them to counter(9), which fixes both issues, >and I note that kern.crypto_stats was renamed to kern.crypto.stats in >HEAD so presumably we can use this opportunity to break the sysctl ABI >as well (the counters have to be widened from 32 bits to 64 bits). >Nothing in the base system seems to actually fetch these counters >outside of some code under tools/, which wasn't updated when the sysctl >was renamed. > >There is also CRYPTO_TIMING, which attempts to measure the time elapsed >during various stages of cryptop processing. This similarly assumes >that processing is single-threaded and I guess is really only useful to >OCF driver developers. It has been in the tree for a very long time, >but has anyone actually used it? I would like to remove it since it >complicates the above-mentioned patch and is of limited usefulness in >SMP systems. DTrace or some per-cryptop scheme could be used instead if >it is really worth having that functionality, but I don't want to write >a patch to implement that unless someone really wants it. >_______________________________________________ >freebsd-hackers@freebsd.org mailing list >https://lists.freebsd.org/mailman/listinfo/freebsd-hackers >To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" I mean, I really like dtrace, but I won't _force_ you to write it. I'll just applaud loudly if you do. :) Yours, Daniel Ebdrup Jensen --fsh3nvpqkl5age7d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEDonNJPbg/JLIMoS6Ps5hSHzN87oFAl7jrh5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDBF ODlDRDI0RjZFMEZDOTJDODMyODRCQTNFQ0U2MTQ4N0NDREYzQkEACgkQPs5hSHzN 87qmLAf8CpNEs0iQ49QFsSfyws7Jb+z45W7ulXcDs5ely/ipJj4JJ6LiowdhgDcv PZ7XbiMhfjpojqznss3I8qSeoijoy39HQ7g0iscI1+Y/mLnYqnKpYoMOXxDINVdU 5qd5KgDNsht5Mvopm4DgeOWDYzXXRvOgVKJvw+NxOq6cjjkakOPppfRVQ75oRjmm vxQ6oiMUyACunPzVXmMdhTcHMF/onpqJWkk4Gy7hP7ZCkFaqG3mJJjyqy4WOGcDQ rgbYYVtv4z7Z3WQiFzNkdTV1czaKV0gNwHTUVMJ8JmB1txXZQ6QO6zpm88i5lLip c8CiLpQpL1J3unEbDJBJgOx5BKU/dw== =Nj/3 -----END PGP SIGNATURE----- --fsh3nvpqkl5age7d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200612163230.37ocjvfebolkqiws>