From nobody Sun Oct 29 17:26:22 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SJNby2xL8z4xxpW for ; Sun, 29 Oct 2023 17:26:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SJNby1DjMz4GFT for ; Sun, 29 Oct 2023 17:26:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698600382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bORsBveVJIRIDcXbOWOb/IqKWHMB4Tev2iShBhcAL9g=; b=dM/nVcRIR9mevAAgS2Gr7L+HpHbFcdXMEPD9S8jlRs2gTgX/rLI4Q9+cADYEJAqNir/hS5 03Tpn3+z1rYf8MLvAtDPB8YJF088rqnreWx8qxJm/dka0ptt0yNafnnDJmHi1ZyoENlTtk aa8/F7ziSSDe941WTMW8jfxSKPsSYOfTg9EyD0nNW/7EFcdDnE9bXQg4nsyZ5A5BGf1YQU tVWhPoas4Gg/iFQqs1QOcjLft6yESeyon51d5/jnJR9T1Bdh53elTPKiBsSXd2lPIK2kuK 98WAaRmw6KTj+5/B8rxxOCpl2VTd9lFEvbxgF6o1QnAywA8PC2e57zl9YBJVLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698600382; a=rsa-sha256; cv=none; b=aWRC5pI8XyKoICkpTHFqrfUCKOPWPOQ92NbEYxsqnbAK/507P1eiO/1uQTgnYvJpfT1YAi RJdWFA6Nv93JEw4bRLquAQz3+MDVUtOmrq5vMrKBtbBo+7UZRkp8eXq4C23xp9BzERj2nN o+t/7QBitsVqyVFi2nYiSKqHnU3qIk7MqZzGIcw8XDh8wO1SVoRLBgt/31feEBk7m+UZAv ebyWaV9R8FZEjbaqwHO/bSjrxa4OPZY0wJ1nxiy3KSbluy4eZBObOhJpW5KGbrp/EBf452 DJYjciOAi29G85Ze/ueQ2IWFuKZdC2EPcwklcCLPD0Aa4nOjnQriSzSQ5BsC4Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SJNby0B7PzmjN for ; Sun, 29 Oct 2023 17:26:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39THQLiI072400 for ; Sun, 29 Oct 2023 17:26:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39THQLS1072399 for bugs@FreeBSD.org; Sun, 29 Oct 2023 17:26:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 274795] broken locking in e6000sw Date: Sun, 29 Oct 2023 17:26:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274795 Bug ID: 274795 Summary: broken locking in e6000sw Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: markj@FreeBSD.org CC: mw@FreeBSD.org Commit 469290648005e13b819a19353032ca53dda4378f made e6000sw's implementati= on of miibus_(read|write)reg assume that the softc lock is held. I presume th= at is to avoid lock recursion in e6000sw_attach() -> e6000sw_attach_miibus() -> mii_attach() -> MIIBUS_READREG(). However, the lock assertion in e6000sw_readphy_locked() can fail: panic: Lock e6000sw not exclusively locked @ /usr/home/markj/src/freebsd/sys/dev/etherswitch/e6000sw/e6000sw.c:773 cpuid =3D 0 time =3D 1698599456 KDB: stack backtrace: db_trace_self() at db_trace_self db_trace_self_wrapper() at db_trace_self_wrapper+0x38 vpanic() at vpanic+0x1a0 panic() at panic+0x48 _sx_assert() at _sx_assert+0x100 e6000sw_readphy_locked() at e6000sw_readphy_locked+0x40 gentbi_probe() at gentbi_probe+0x7c device_probe_child() at device_probe_child+0x150=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 device_probe() at device_probe+0xa0=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 device_probe_and_attach() at device_probe_and_attach+0x38=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 bus_generic_attach() at bus_generic_attach+0x1c=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 miibus_attach() at miibus_attach+0x88=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20 device_attach() at device_attach+0x3fc device_probe_and_attach() at device_probe_and_attach+0x80=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 bus_generic_driver_added() at bus_generic_driver_added+0x90 devclass_driver_added() at devclass_driver_added+0x48 devclass_add_driver() at devclass_add_driver+0x148 module_register_init() at module_register_init+0xb4=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 linker_load_module() at linker_load_module+0xacc=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 kern_kldload() at kern_kldload+0x190=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 sys_kldload() at sys_kldload+0x64=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 do_el0_sync() at do_el0_sync+0x59c=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 handle_el0_sync() at handle_el0_sync+0x48 In particular, gentbi_probe() obviously didn't acquire the softc lock. --=20 You are receiving this mail because: You are the assignee for the bug.=