From nobody Sun May 4 22:42:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZrKS14K2hz5vPPw; Sun, 04 May 2025 22:42:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZrKS13Fd5z3MQL; Sun, 04 May 2025 22:42:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746398577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FEZfek7XdT4NTHtkmHjJLZA45n/sN4/B1xuLrZExcEM=; b=mV396o0LYpPyelWmIL/PJi+opg0NTkWrT0B/TdxVbbPkXu4YgXlcsqAj3hwHp5aqAuqjip mxR3baVRZDxy9edVIivwhMWqiDD15ZKBWqpWfvfUSAqpGfDabsVna4QSjXnY8Kgw2knldq zKlTjND7PZPZ9jtF2gdPUFhpLFKnb9pJHyLJit5RaabNtrFNGSIAyvoJhGpwU2JGXBuDEs qzhumlP4vWeXzePaZmEgOngrcsRMduTJ0S65+IB45r6ulhtK9A9PM2sdjNw9vRkiC9wx17 +N93yT9O70J9NPlflaLAlfb264AQuCeZa5y1rF3LDMLiDv0NlrOTG8RIxWX/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746398577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FEZfek7XdT4NTHtkmHjJLZA45n/sN4/B1xuLrZExcEM=; b=Qgssn80Xi4t7hbIvXGNS2LG3sK/yvQdUq5Xym88U2Hi/P1pCQWQVMEvDGGkmpFdsT6rKTJ Jkakb/niYij4JamrsgCTetCPgCc2l9Grvct7jyI/tJTVu5Lp9/W57Ff1GgijtvmZllU6wt uo/GOZ7MUZksz26rj43ZOu7CRAoiZ5yyej61a7eHfOTaVQwXRuRcsWLmAM/ci0ZuNb4PwL vB3RRWY7xt/fNQpxehn7JbR2FpzVCMmthACQHRhkhR7ou/cPu6IEMzCQXcpGxELCqTe7VK va8K0pqlgbriSbDnQ0+kf84i1RlOnhh9uDGoL3AsiNc3EZGvS6EBzapWYDXDEw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746398577; a=rsa-sha256; cv=none; b=qY3eRx8dIp7AnIufIvZrI0YAf9jE+qzNGiKHEVx68dK73mMIfag6Bxqqwk3IzZLSV/aISc ffATsUQtGnKI6GohL3dNWp6OPlaAg/whluw0ABfrOfLT/T5QCabQvJXu+JdbTppbVOF6Kj +mEghMsYUFbkIWIJRxHo2KPARfVxHDZZRuH+8lrID5ZJEUJ6Fc4nFSQlGMXQzm9B3SNLF8 SnKX6d5+xnOouJdhFNSfKnDqX70sTfHWwI1ckAYwg1HxnCyLDbQr+KHLncCWVdhdQHP/Vg CBomSjZuEk8IYBJPbPSmHU/FtqjtH5BZ8Jb9/TNeETUan5m9QvnB7qelQVhhZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZrKS12s4jzp4Q; Sun, 04 May 2025 22:42:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 544MgvR9098236; Sun, 4 May 2025 22:42:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 544MgvHc098234; Sun, 4 May 2025 22:42:57 GMT (envelope-from git) Date: Sun, 4 May 2025 22:42:57 GMT Message-Id: <202505042242.544MgvHc098234@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 6ab4b0c0df57 - main - sctp: initilize local address flags correctly List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6ab4b0c0df57775fd6c288a0b7d0f5d2cad73481 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=6ab4b0c0df57775fd6c288a0b7d0f5d2cad73481 commit 6ab4b0c0df57775fd6c288a0b7d0f5d2cad73481 Author: Michael Tuexen AuthorDate: 2025-05-04 22:41:49 +0000 Commit: Michael Tuexen CommitDate: 2025-05-04 22:41:49 +0000 sctp: initilize local address flags correctly Use the same routine for initilizing as for updating. MFC after: 3 days --- sys/netinet/sctp_pcb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netinet/sctp_pcb.c b/sys/netinet/sctp_pcb.c index 9c9dd0cf3462..13d3b0a332f9 100644 --- a/sys/netinet/sctp_pcb.c +++ b/sys/netinet/sctp_pcb.c @@ -453,6 +453,7 @@ sctp_add_addr_to_vrf(uint32_t vrf_id, void *ifn, uint32_t ifn_index, SCTPDBG(SCTP_DEBUG_PCB4, "Clearing deleted ifa flag\n"); sctp_ifap->localifa_flags = SCTP_ADDR_VALID; + sctp_gather_internal_ifa_flags(sctp_ifap); sctp_ifap->ifn_p = sctp_ifnp; atomic_add_int(&sctp_ifap->ifn_p->refcount, 1); } @@ -475,6 +476,7 @@ sctp_add_addr_to_vrf(uint32_t vrf_id, void *ifn, uint32_t ifn_index, } else { /* Repair ifn_p, which was NULL... */ sctp_ifap->localifa_flags = SCTP_ADDR_VALID; + sctp_gather_internal_ifa_flags(sctp_ifap); SCTPDBG(SCTP_DEBUG_PCB4, "Repairing ifn %p for ifa %p\n", (void *)sctp_ifnp, (void *)sctp_ifap); @@ -499,7 +501,7 @@ sctp_add_addr_to_vrf(uint32_t vrf_id, void *ifn, uint32_t ifn_index, sctp_ifap->ifa = ifa; memcpy(&sctp_ifap->address, addr, addr->sa_len); sctp_ifap->localifa_flags = SCTP_ADDR_VALID | SCTP_ADDR_DEFER_USE; - sctp_ifap->flags = ifa_flags; + sctp_gather_internal_ifa_flags(sctp_ifap); /* Set scope */ switch (sctp_ifap->address.sa.sa_family) { #ifdef INET