From owner-cvs-ports@FreeBSD.ORG Sun Jan 2 22:53:19 2005 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9685C16A4CE; Sun, 2 Jan 2005 22:53:19 +0000 (GMT) Received: from mail2out.barnet.com.au (mail2out.barnet.com.au [202.83.176.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D62943D2F; Sun, 2 Jan 2005 22:53:18 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: by mail2out.barnet.com.au (Postfix, from userid 27) id E2FC7707428; Mon, 3 Jan 2005 09:53:16 +1100 (EST) X-Viruscan-Id: <41D87B5C00012B7171E34F@BarNet> Received: from mail2-auth.barnet.com.au (mail2.barnet.com.au [202.83.176.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) Authority" (verified OK)) by mail2.barnet.com.au (Postfix) with ESMTP id A0308707426; Mon, 3 Jan 2005 09:53:16 +1100 (EST) Received: from k7.mavetju (edwin-3.int.barnet.com.au [10.10.12.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) Certificate Authority" (verified OK)) by mail2-auth.barnet.com.au (Postfix) with ESMTP id EEADB7073CE; Mon, 3 Jan 2005 09:53:15 +1100 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id C3D0B60EA; Mon, 3 Jan 2005 09:53:14 +1100 (EST) Date: Mon, 3 Jan 2005 09:53:14 +1100 From: Edwin Groothuis To: Kris Kennaway Message-ID: <20050102225314.GJ63708@k7.mavetju> References: <200501020116.j021GBqD070105@repoman.freebsd.org> <20050102064857.GA4047@frontfree.net> <20050102065949.GB6250@xor.obsecurity.org> <20050102070800.GA106@frontfree.net> <20050102071136.GD1436@k7.mavetju> <20050102071849.GA31292@xor.obsecurity.org> <20050102112037.GE1436@k7.mavetju> <20050102201818.GA42186@xor.obsecurity.org> <20050102213206.GI63708@k7.mavetju> <20050102223941.GA75006@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050102223941.GA75006@xor.obsecurity.org> User-Agent: Mutt/1.5.6i cc: cvs-ports@FreeBSD.org cc: ports-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Xin LI Subject: Re: cvs commit: ports/mail/postfix-gps Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jan 2005 22:53:19 -0000 On Sun, Jan 02, 2005 at 02:39:41PM -0800, Kris Kennaway wrote: > On Mon, Jan 03, 2005 at 08:32:06AM +1100, Edwin Groothuis wrote: > > On Sun, Jan 02, 2005 at 12:18:18PM -0800, Kris Kennaway wrote: > > > On Sun, Jan 02, 2005 at 10:20:37PM +1100, Edwin Groothuis wrote: > > > > > > > > The problem is that INDEX builds also need to set this or the > > > > > dependency list will be all wrong. Doing this the obvious way gives a > > > > > huge slowdown. > > > > > > > > What are the obvious ways? This is what I made in a galaxy far far > > > > away when I still had the hope I could change the world. What is > > > > does is when PACKAGE_BUILDING is defined it sets the default WITH_ > > > > and WITHOUT_ values are being set. > > > > > > And that gives a huge slowdown, because of all the extra make/shell > > > gunk that is processed 12000 times :) > > > > I couldn't find a single shell command in this. > > OK (I might have been confusing it with the slowdown that happened > along with a previously-committed OPTIONS-related change) but did you > benchmark it? I would like to, but at this moment I'm not sure what and how: - It doesn't have any impact on ports when PACKAGE_BUILDING isn't set. - It doesn't have any impact on ports which don't use OPTIONS. - When running it without PACKAGE_BUILDING set, it takes half a second for databases/libdbi-drivers. When running it with PACKAGE_BUILDING set, it takes 2.5 seconds. Why? Because it has to go through the databases/mysql40-client and databases/postgresql7 ports and find their dependencies. So yes with this patch it's slower, but that is because it does do all the intended work instead of bailing out halfway. -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/