From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Nov 12 10:50:34 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2993B16A4CE for ; Fri, 12 Nov 2004 10:50:34 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0D9343D1F for ; Fri, 12 Nov 2004 10:50:33 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) iACAoX93049692 for ; Fri, 12 Nov 2004 10:50:33 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iACAoXqp049691; Fri, 12 Nov 2004 10:50:33 GMT (envelope-from gnats) Resent-Date: Fri, 12 Nov 2004 10:50:33 GMT Resent-Message-Id: <200411121050.iACAoXqp049691@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Trejkaz Xaoza Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4385616A4CE for ; Fri, 12 Nov 2004 10:49:57 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3473343D2D for ; Fri, 12 Nov 2004 10:49:57 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id iACAnuwt016662 for ; Fri, 12 Nov 2004 10:49:56 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id iACAnuHT016661; Fri, 12 Nov 2004 10:49:56 GMT (envelope-from nobody) Message-Id: <200411121049.iACAnuHT016661@www.freebsd.org> Date: Fri, 12 Nov 2004 10:49:56 GMT From: Trejkaz Xaoza To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: ports/73861: segfault on jabber-yahoo-2.3.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2004 10:50:34 -0000 >Number: 73861 >Category: ports >Synopsis: segfault on jabber-yahoo-2.3.2 >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 12 10:50:33 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Trejkaz Xaoza >Release: unsure (hosting box) >Organization: Individual >Environment: FreeBSD mail.zim.com.au 5.2.1-RELEASE-p9 FreeBSD 5.2.1-RELEASE-p9 #0: Fri Aug 13 01:12:37 GMT 2004 mark@mail.zim.com.au:/usr/obj/usr/src/sys/GENERIC i386 >Description: There is a segfault issue in the current Yahoo Transport which is expected to be fixed in the next version. >How-To-Repeat: The server exhibits the problem by itself, given enough time. It's somehow related to a malformed presence packet from certain clients. >Fix: Patch: --- yahoo.c.orig 2004-07-27 15:00:19.538066636 -0700 +++ yahoo.c 2004-07-27 15:01:11.391272012 -0700 @@ -224 , 6 +224 , 7 @@ GSList *l; int len = 0; + char *fix; l = pkt->hash; while (l) { @@ -234 , 7 +235 , 15 @@ len++; } while (tmp); len += 2; - len += strlen(pair->value); + if (pair->value == NULL) { + + fix = malloc(1); + *fix = 0; + pair->value = fix; + + log_debug(ZONE , " [YAHOO]: Corrected Key Now: %d tValue: %sn " , pair->key , pair->value); + } + len += pair->value == NULL ? 0 : strlen(pair->value); len += 2; l = l->next; } >Release-Note: >Audit-Trail: >Unformatted: