From owner-freebsd-ports@FreeBSD.ORG  Tue Jul  8 12:04:18 2014
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 995A474E
 for <freebsd-ports@freebsd.org>; Tue,  8 Jul 2014 12:04:18 +0000 (UTC)
Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 50A6A2B19
 for <freebsd-ports@freebsd.org>; Tue,  8 Jul 2014 12:04:18 +0000 (UTC)
Received: from pi by home.opsec.eu with local (Exim 4.82 (FreeBSD))
 (envelope-from <pi@opsec.eu>)
 id 1X4U85-000Dao-K9; Tue, 08 Jul 2014 14:04:13 +0200
Date: Tue, 8 Jul 2014 14:04:13 +0200
From: Kurt Jaeger <pi@opsec.eu>
To: "A.J. 'Fonz' van Werven" <freebsd@skysmurf.nl>
Subject: Re: [Bugzilla] How to approve patches?
Message-ID: <20140708120413.GG2586@home.opsec.eu>
References: <20140708115442.GA59520@biertje.skysmurf.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140708115442.GA59520@biertje.skysmurf.nl>
Cc: FreeBSD ports mailing list <freebsd-ports@freebsd.org>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jul 2014 12:04:18 -0000

Hi!

> A helpful someone submitted a PR with a patch for a port I maintain. I
> remember that back in the GNATS days, when this happened I had to reply to
> an e-mail if I approved of the patch. But with Bugzilla I'm not sure. I
> added a comment to the PR that said "Maintainer approved", but I don't
> know whether that's the right way to do things.

That is sufficient to approve it, if it's easy to spot that
you are the committer, that means if the value of the MAINTAINER
field in the Makefile matches the mail address that "approved" in the PR.

> So, in short: with the new Bugzilla system, how does a maintainer (who is
> not a committer) respond to a PR in order to get the patch committed?

Next step would be to tack the PR to an committer willing to commit it 8-)

A short mail to ports@ with "can some committer please commit PR ..." is
one way to find one. It might get noisy in the future 8-}

-- 
pi@opsec.eu            +49 171 3101372                         6 years to go !