From owner-freebsd-ruby@freebsd.org Fri Oct 23 19:31:07 2015 Return-Path: Delivered-To: freebsd-ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD3E4A1D994 for ; Fri, 23 Oct 2015 19:31:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B30B48F5 for ; Fri, 23 Oct 2015 19:31:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B1B16A1D992; Fri, 23 Oct 2015 19:31:07 +0000 (UTC) Delivered-To: ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1516A1D991 for ; Fri, 23 Oct 2015 19:31:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 88F2F8F2 for ; Fri, 23 Oct 2015 19:31:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t9NJV7hw050507 for ; Fri, 23 Oct 2015 19:31:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: ruby@FreeBSD.org Subject: maintainer-feedback requested: [Bug 203988] lang/ruby21 - readline & libedit configure options spelled wrong Date: Fri, 23 Oct 2015 19:31:07 +0000 X-Bugzilla-Type: request Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 19:31:08 -0000 John Hein has reassigned Bugzilla Automation 's request for maintainer-feedback to ruby@FreeBSD.or= g: Bug 203988: lang/ruby21 - readline & libedit configure options spelled wrong https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203988 --- Description --- Created attachment 162400 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D162400&action= =3Dedit [patch] fix --with-libedit/readline* configuration arg spellings and enable them for libedit in the readline module's extconf.rb The --with-readline-prefix and --with-libedit-prefix configure arguments are spelled wrong. They should be --with-readline-dir and --with-libedit-dir. = See dir_config() inlib/mkmf.rb It's just luck in the normal default case that the ports do the right thing now. You could spell them --with-libedit-flibberjam=3D${LOCALBASE} and it = would still work (in the default case). Because -I/usr/local/include is added for other reasons and normally /usr/local (LOCALBASE) is where the readline and libedit ports are installed. For instance, if you select the LIBEDIT option and have devel/libedit insta= lled to a different prefix than LOCALBASE, then setting --with-libedit-prefix=3D (you have to change the current port Makefile to test that since it's hard-coded to ${LOCALBASE} instead of the results from 'pkgconf --variable prefix libedit') will fail to find the rig= ht libedit and you'll get issues like this because the ruby build finds and us= es the libedit from base: compiling readline.c readline.c: In function 'history_get_offset_history_base': readline.c:1573: error: 'history_base' undeclared (first use in this functi= on) readline.c:1573: error: (Each undeclared identifier is reported only once readline.c:1573: error: for each function it appears in.) readline.c: In function 'hist_get': readline.c:1585: error: 'HIST_ENTRY' undeclared (first use in this function) readline.c:1585: error: 'entry' undeclared (first use in this function) readline.c:1590: error: 'history_length' undeclared (first use in this function) readline.c: In function 'hist_set': readline.c:1605: error: 'HIST_ENTRY' undeclared (first use in this function) . . Furthermore, I believe there's a bug in ext/readline/extconf.rb in the libe= dit case where the --with-libedit* feature is not turned on - it needs 'dir_config("libedit")'. That part of the attached patch can be submitted upstream. I'll try to do that if no one else beats me to it. This bug is something of a nitpick since everything works in the default everything-in-/usr/local case now. But the configure option is definitely spelled wrong. And those --with-libedit* knobs need to be enabled in readline/extconf.rb for libedit.=