From owner-freebsd-hackers Mon Dec 6 11:12:54 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 78FAB15A08 for ; Mon, 6 Dec 1999 11:12:39 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.3/8.9.1) id JAA70797; Mon, 6 Dec 1999 09:54:46 -0800 (PST) (envelope-from dillon) Date: Mon, 6 Dec 1999 09:54:46 -0800 (PST) From: Matthew Dillon Message-Id: <199912061754.JAA70797@apollo.backplane.com> To: Alfred Perlstein Cc: hackers@FreeBSD.ORG Subject: Re: vfs_bio questions/nfs cluster commit References: Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I haven't finished looking at the whole thing yet, but I see one immediate (trivial to fix) problem: + BUF_LOCK(holdbp, LK_EXCLUSIVE)) I would recommend getting a *NON* blocking lock, and bumping your gap mechanism if you can't get the lock (and not store the buffer). Otherwise you may create a deadlock situation elsewhere. - Alred, in your followup email you said something about the existing clustering being broken. It seems to work for me (64KB clustering), could you give me an example? NFS clustering is based very heavily only VFS clustering. If you aren't seeing NFS clustering for commit messages then perhaps VFS clustering got broken somehow... -Matt :I've been trying to workout mega-clusters for NFS, since afaik the :vfs_cluster code will only do 64k chunks and we can benifit greatly :by compacting ranges for commit RPCs. :... : :Index: nfs_bio.c :=================================================================== :RCS file: /home/ncvs/src/sys/nfs/nfs_bio.c,v :retrieving revision 1.80 :... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message