Date: Mon, 18 Jun 2001 02:38:29 +0200 (CEST) From: rguyom@pobox.com To: FreeBSD-gnats-submit@freebsd.org Cc: jmz@freebsd.org Subject: ports/28245: bug in x11/xloadimage -tile option Message-ID: <20010618003829.644CC277@diabolic-cow.chatgris.net>
next in thread | raw e-mail | index | archive | help
>Number: 28245
>Category: ports
>Synopsis: bug in x11/xloadimage -tile option
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Jun 17 17:40:08 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: Rémi Guyomarch
>Release: FreeBSD 4.3-STABLE i386
>Organization:
none
>Environment:
System: FreeBSD diabolic-cow.chatgris.net 4.3-STABLE FreeBSD 4.3-STABLE #7: Sun Apr 22 21:57:27 CEST 2001 root@diabolic-cow.chatgris.net:/usr/obj/usr/src/sys/DIABOLIC-COW i386
Port: xloadimage-4.1.6
>Description:
See next section.
>How-To-Repeat:
xloadimage -tile <some_image_file_smaller_in_x_and_y_than_your_screen>
>Fix:
--- merge.c~ Thu Oct 21 22:28:39 1993
+++ merge.c Mon Jun 18 02:23:58 2001
@@ -244,6 +244,7 @@
int x, y;
unsigned int width, height, verbose;
{ Image *base, *tmp;
+ int nx, ny;
if (verbose) {
printf(" Tiling...");
@@ -259,16 +260,14 @@
else
base = newTrueImage(width, height);
- while (x < base->width) {
- while(y < base->height) {
- tmp = merge(base, image, x, y, 0);
+ for (nx = x; nx < base->width; nx += image->width) {
+ for(ny = y; ny < base->height; ny += image->height) {
+ tmp = merge(base, image, nx, ny, 0);
if (tmp != base) {
freeImage(base);
base = tmp;
}
- y += image->width;
}
- x += image->width;
}
printf("done.\n");
return(base);
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010618003829.644CC277>