Date: Wed, 1 Jun 2005 11:31:26 -0400 From: Tom Rhodes <trhodes@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: delphij@delphij.net, freebsd-arch@FreeBSD.org Subject: Re: [PATCH RFC] Add a macro for null mount options to sbin/mount* Message-ID: <20050601113126.2949ff1e@mobile.pittgoth.com> In-Reply-To: <20050601211628.V96009@delplex.bde.org> References: <1117613456.771.16.camel@spirit> <20050601211628.V96009@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 1 Jun 2005 21:23:23 +1000 (EST)
Bruce Evans <bde@zeta.org.au> wrote:
> On Wed, 1 Jun 2005, Xin LI wrote:
Here we go again! :P
>
> > In our mount* utilities, the null mount option, which is usually be used
> > as a terminator of an option vector, is defined with some hand-rolled
> > terms, e.g.: {NULL}, {NULL, 0, 0, 0}, etc.
>
> "{ NULL }" is the documented way. See getmntopts.3.
That manual page has been unhooked since it's import IIRC.
>
> > I think it would be nice to have a new macro to deal with this, say,
> > MOPT_NULL, which would be extended to {NULL, 0, 0, 0}, which can act as
> > an explicit initialize. And in my opinion, something like:
> >
> > %%%
> > opt = {
> > MOPT_STD,
> > MOPT_NULL
> > };
> > %%%
>
> MOPT_NULL is a poor name. It is not a null option, but a terminator that
> happens to have nulls in it.
But MOPT_END is a better name, I like it. :)
--
Tom Rhodes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050601113126.2949ff1e>