From owner-svn-src-head@freebsd.org Sat Aug 22 14:27:43 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1CBC03BD4B5; Sat, 22 Aug 2020 14:27:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYghZ5Xq3z4j7M; Sat, 22 Aug 2020 14:27:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x829.google.com with SMTP id 6so3272217qtt.0; Sat, 22 Aug 2020 07:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZZmGdGdatdDqI691EvaL/f7YJcyRFyBrEgl5conl/A4=; b=fyylmBKvwqPdeU4MzEuI1F2TFh6nAG10K2zu9MvfyKxWxz8WvmPrOekBMJrqVlfW+m er5wXotuqw8WIMdXnVdsEQn/MUJIFtZPqUZJaPV/LRu5xVL9T73A9IguEltL05U/rCxz ukKfId0W+xYqkeleainy1DCquGta+5MhhVE8r1pZnKWxSNXFrOOruZOce51g/jAaV6yv XM61Gi5cp3p3rhOTh3wkPPVbr/1YSTgzAbXbfQBvWcBi4Ko2F5vq75fvUEinlYbfomR/ a73/Pm55zWoLWOl4+aVUg4NJcavoVaLjSs8mIIkJM/T2xFA/w0wZhTx85YS2dPrwt1XK UQyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=ZZmGdGdatdDqI691EvaL/f7YJcyRFyBrEgl5conl/A4=; b=aCBfuSHjxBLt3nBhvfq28xY+AmQaZLRSUeQ7tAlRXpcQQQodHhG3p3ev25Zn7VeYMC BbPyAzLznVeIwqCBt0v9CK/T1ChsKGaDtnMdf7a63QZ3orVHGwdLVj3W68S5Y7WCzLea gzUm7g/EFla1SlbXfU+7//vsZFjk9dQguatMsSOo37T/XhcCuGnLS6ZjRpX0Q51Iyrg4 gytEvdZMUhE/4YvuOno86IUqYKfmvXI+GA91GzUZ8B8T/VrEDACCL3gsPxyQ7SAGLmgh TGGrUnMse/L3KuZYWdGxCEVr2CT0uA8ogSN/6j+2jsQyp5ZyA50U6Wo4osIC6bF39zIJ fXmQ== X-Gm-Message-State: AOAM5307qyFOYTkeQ8Iuh3UFHUQHhrwskWIHAkZATFXgeIc4PAzpsJkv /zdWQ+7W6FCpDgdX04hWR3LqzTlIPiIbeg== X-Google-Smtp-Source: ABdhPJzff+NzrEdEurSN0mlw1DnN4Fp7X55p1ykPxGiiLjyEoQCm+pTYz0x77lCiboRSv5O+YWtdag== X-Received: by 2002:aed:2782:: with SMTP id a2mr6641061qtd.289.1598106461129; Sat, 22 Aug 2020 07:27:41 -0700 (PDT) Received: from raichu (toroon0560w-lp130-08-67-71-176-35.dsl.bell.ca. [67.71.176.35]) by smtp.gmail.com with ESMTPSA id l38sm5685774qtl.58.2020.08.22.07.27.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2020 07:27:40 -0700 (PDT) Sender: Mark Johnston Date: Sat, 22 Aug 2020 10:27:36 -0400 From: Mark Johnston To: Antoine Brodin Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Subject: Re: svn commit: r364438 - in head/cddl: contrib/opensolaris/lib/libdtrace/common usr.sbin/dtrace/tests/tools Message-ID: <20200822142736.GA57199@raichu> References: <202008201928.07KJSJfP088877@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4BYghZ5Xq3z4j7M X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 14:27:43 -0000 On Sat, Aug 22, 2020 at 12:40:49PM +0200, Antoine Brodin wrote: > On Thu, Aug 20, 2020 at 9:28 PM Mark Johnston wrote: > > > > Author: markj > > Date: Thu Aug 20 19:28:19 2020 > > New Revision: 364438 > > URL: https://svnweb.freebsd.org/changeset/base/364438 > > > > Log: > > Enable creation of static userspace probes in incremental builds. > > > > To define USDT probes, dtrace -G makes use of relocations for undefined > > symbols: the target address is overwritten with NOPs and the location is > > recorded in the DOF section of the output object file. To avoid link > > errors, the original relocation is destroyed. However, this means that > > the same input object file cannot be processed multiple times, as > > happens during incremental rebuilds. Instead, only set the relocation > > type to NONE, so that all information required to reconstruct USDT > > probes is preserved. > > > > Reported by: bdrewery > > MFC after: 3 weeks > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c > > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.c > > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.h > > head/cddl/usr.sbin/dtrace/tests/tools/exclude.sh > > Hi, > > This change seems broken on i386: > > http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5-devel-5.33.0.262.log > http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5.28-5.28.3.log > http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5.30-5.30.3.log > http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5-5.32.0.log The links are dead, but I think the problem should be fixed by r364483. > > Cheers, > > Antoine