Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 May 2015 18:12:34 +0000 (UTC)
From:      Mariusz Zaborski <oshogbo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r282350 - head/sys/kern
Message-ID:  <201505021812.t42ICYaU010882@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: oshogbo
Date: Sat May  2 18:12:34 2015
New Revision: 282350
URL: https://svnweb.freebsd.org/changeset/base/282350

Log:
  nv_malloc can fail in userland.
  Add check to prevent a NULL pointer dereference.
  
  Pointed out by:	mjg
  Approved by:	pjd (mentor)

Modified:
  head/sys/kern/subr_nvlist.c

Modified: head/sys/kern/subr_nvlist.c
==============================================================================
--- head/sys/kern/subr_nvlist.c	Sat May  2 18:10:45 2015	(r282349)
+++ head/sys/kern/subr_nvlist.c	Sat May  2 18:12:34 2015	(r282350)
@@ -129,6 +129,8 @@ nvlist_create(int flags)
 	PJDLOG_ASSERT((flags & ~(NV_FLAG_PUBLIC_MASK)) == 0);
 
 	nvl = nv_malloc(sizeof(*nvl));
+	if (nvl == NULL)
+		return (NULL);
 	nvl->nvl_error = 0;
 	nvl->nvl_flags = flags;
 	nvl->nvl_parent = NULL;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201505021812.t42ICYaU010882>