Date: Fri, 16 Mar 2001 23:50:52 +0000 From: Jonathan Perkin <sketchy@bsdcode.net> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/ngctl Makefile main.c Message-ID: <20010316235052.A23352@ns0.netcraft.com>
next in thread | raw e-mail | index | archive | help
> phk 2001/03/16 11:35:08 PST > > Modified files: > usr.sbin/ngctl Makefile main.c > Log: > Add -ledit to ngctl. > > Somebody submitted this long time ago, and it has been sitting in my > tree for months because I thought archie would pick it up. > > Submitted by: (sorry, lost track) It was submitted by me, and unfortunately it needs to be backed out as it completely and utterly does not work :) editline(3) blocks completely, so any checks for Netgraph control or data messages are ignored and never printed - easy way to check is: + mkpeer ksocket foo inet/stream/tcp + msg foo connect inet/127.0.0.1:13 ngctl: send msg: Operation now in progress + which should have responded with daytime info. I've been working on a newer version of this patch which is based on pppctl(8) using pthreads which is currently up at http://www.bsdcode.net/ngctl.patch - unfortunately it runs into some threading issues which Archie informed me off which I haven't worked out how to fix yet: + msg foo connect inet/127.0.0.1:13 ngctl: send msg: Operation now in progress + Rec'd data packet on hook "foo": 0000: 46 72 69 20 4d 61 72 20 31 36 20 32 33 3a 33 38 Fri Mar 16 23:38 0010: 3a 32 37 20 32 30 30 31 0d 0a :27 2001.. Fatal error '_waitq_remove: Not in queue' at line 317 in file /usr/src/lib/libc_r/uthread/uthread_priority_queue.c (errno = 35) Abort (core dumped) Exit 134 If anyone has any tips on what's wrong (I keep meaning to ask on -hackers), I'd appreciate any pointers as I'm very low on pthread clue. Jon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010316235052.A23352>