From owner-freebsd-stable@freebsd.org Wed Oct 5 12:37:34 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3CE45AF33B5 for ; Wed, 5 Oct 2016 12:37:34 +0000 (UTC) (envelope-from torfinn.ingolfsen@getmail.no) Received: from bouvier.getmail.no (bouvier.getmail.no [84.210.184.8]) by mx1.freebsd.org (Postfix) with ESMTP id D6897837 for ; Wed, 5 Oct 2016 12:37:33 +0000 (UTC) (envelope-from torfinn.ingolfsen@getmail.no) Received: from localhost (localhost [127.0.0.1]) by bouvier.getmail.no (Postfix) with ESMTP id CBCE650027 for ; Wed, 5 Oct 2016 14:37:24 +0200 (CEST) Received: from bouvier.getmail.no ([127.0.0.1]) by localhost (bouvier.get.c.bitbit.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 11LrARtQC16W for ; Wed, 5 Oct 2016 14:37:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by bouvier.getmail.no (Postfix) with ESMTP id 5151A5007E for ; Wed, 5 Oct 2016 14:37:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.8.4 bouvier.getmail.no 5151A5007E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=getmail.no; s=8A9C8B4C-D727-11E2-8095-B6466E6B3FA2; t=1475671044; bh=LlZZcrb/+V35OhsVi/lPSMQHBbf6PwiqnAW61DvRmjk=; h=Date:From:To:Subject:Message-Id:Mime-Version:Content-Type: Content-Transfer-Encoding; b=47R1usbT0PKLIv5Gc6cXT2d4eteov83aouJqXEWwgX7JUVu85OeIkiruDyWG5dpVM POTEXUnTm+xKkValS47O5OlNFWLhJwpRk9gZUvdmbcG1B9sNGMm1+8m4tz9nWuLjp2 8tfwg6QRY2I56fqQ7/WKTSYqSAm084ShrMzJtFMU= X-Virus-Scanned: amavisd-new at bouvier.get.c.bitbit.net Received: from bouvier.getmail.no ([127.0.0.1]) by localhost (bouvier.get.c.bitbit.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DM306B7Nu8da for ; Wed, 5 Oct 2016 14:37:24 +0200 (CEST) Received: from kg-core1.kg4.no (cm-84.209.39.108.getinternet.no [84.209.39.108]) by bouvier.getmail.no (Postfix) with ESMTPSA id 2AC6450027 for ; Wed, 5 Oct 2016 14:37:24 +0200 (CEST) Date: Wed, 5 Oct 2016 14:37:23 +0200 From: Torfinn Ingolfsen To: freebsd-stable@freebsd.org Subject: Re: aibs(4) / atk0110 support for newer systems Message-Id: <20161005143723.4273657959160b67637a5adf@getmail.no> In-Reply-To: References: <86cf8380-ac6f-55f0-f0f8-16000d7f04b2@FreeBSD.org> <20160930145704.4dbc9d90011154b38493964e@getmail.no> <7d498084-ec05-d4c9-5f49-6aef32495caf@FreeBSD.org> <20160930205928.77d7e74f7bd1a35fcf1aa50a@getmail.no> <7a868c22-e0bd-f677-e4ad-2bdf6f3605d0@FreeBSD.org> <20161003201511.7258687453f12c44a46a361a@getmail.no> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.29; amd64-portbld-freebsd9.3) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 12:37:34 -0000 On Mon, 3 Oct 2016 23:05:48 +0300 Andriy Gapon wrote: > Yes, it does. Thank you! > It seems like a couple of minor changes are not in the source tree that you are > using. One is some casts in a diagnostic printf and the other is a different > rounding of 0C in Kelvins. > I've generated a patch that should apply to your tree: > https://people.freebsd.org/~avg/aibs-ggrp-gitm.93.diff > Please try. The patch applied cleanly (I removed the old one with patch -R first): root@kg-core1# patch -p0 < /home/tingo/dl/aibs-ggrp-gitm.93.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/dev/acpi_support/atk0110.c |=================================================================== |--- sys/dev/acpi_support/atk0110.c (revision 306109) |+++ sys/dev/acpi_support/atk0110.c (working copy) -------------------------- Patching file sys/dev/acpi_support/atk0110.c using Plan A... Hunk #1 succeeded at 28. Hunk #2 succeeded at 52. Hunk #3 succeeded at 78. Hunk #4 succeeded at 91. Hunk #5 succeeded at 124. Hunk #6 succeeded at 134. Hunk #7 succeeded at 362. Hunk #8 succeeded at 370. Hunk #9 succeeded at 377. Hunk #10 succeeded at 391. Hunk #11 succeeded at 435. Hunk #12 succeeded at 450. Hunk #13 succeeded at 457. Hunk #14 succeeded at 488. Hunk #15 succeeded at 495. done However, build fails: root@kg-core1# pwd /sys/modules/acpi/aibs root@kg-core1# make Warning: Object directory not changed from original /usr/src/sys/modules/acpi/aibs @ -> /usr/src/sys machine -> /usr/src/sys/amd64/include x86 -> /usr/src/sys/x86/include :> opt_acpi.h awk -f @/tools/makeobjops.awk @/dev/acpica/acpi_if.m -h awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h awk -f @/tools/makeobjops.awk @/kern/device_if.m -h :> opt_ddb.h cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -c /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c -o atk0110.o cc1: warnings being treated as errors /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c: In function 'aibs_attach': /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252: warning: 's_idx' may be used uninitialized in this function /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252: note: 's_idx' was declared here /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256: warning: 'so' may be used uninitialized in this function /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256: note: 'so' was declared here /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253: warning: 'name' may be used uninitialized in this function /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253: note: 'name' was declared here *** [atk0110.o] Error code 1 Stop in /usr/src/sys/modules/acpi/aibs. Do I have to do something more in order to build the new module? -- Torfinn Ingolfsen