From nobody Fri Jul 4 20:26:08 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bYlX137SGz60lGW; Fri, 04 Jul 2025 20:26:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bYlX05Kv1z3sr0; Fri, 04 Jul 2025 20:26:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hXCOIUj2g249aoN+IwQR7OO/KnuBNEiA9lKAkrwCZN4=; b=lLR+MykMMqXUHC2w8MVye1Nw1/nxV3ikbFYjPIspIOAgezCKJQgI1u/hymhzq/Pqn8LehQ SkRy9tILavg7dzIZkn4yAq3XxE4zN88Kl7CoyDHEpQuCt74pTniQEL5k8VdfxOTaTDuVkj 2otL0yZFE2JMq0mtjZkIewxeTAnKgzsiPuxtk3Bk35az/UCyVf6ayEIK9JtzJPaPz3qKDv Hy2xFnlcbw5WGoA98WSh//iD1YUfxnknzeSneGCZy/M5jbOcbsKBXOQU3Zo9mo7RdbWqNb CeZDo0aiG2kJvowIouNPU2jLmEys4dihtL9gL8PIT5P9YW+504AxVZUeDssgnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hXCOIUj2g249aoN+IwQR7OO/KnuBNEiA9lKAkrwCZN4=; b=on8rsC6mlr1dZ4ia4nXx9HWPt2RfrlmMBOjcDgPnVMzc/P+T8I8LW7gDu0EyWWM5E/mm7z j5l7rbkzrI9oL8VBKaRl0UQcDMf2vwe8YVhx99jQRsgmyfB5KmZsjhDWsEMNi65TzDKe0x ZGaQ3MAPMW5i/kPcweDmHkniPz4kKV17iEszsPYz7R7ug6WcPFo5uUnJYp2z4uGPMl1HK6 qo+HMcDfSy1Zhgou/1XGd3kQ9Hd85kPkH0W6pM9Y915UgAEUYWwgcfEHUUyMg/xr4IVv2G h6FJvinO8HQKQpKrlRK1MZW4Z3RnPwigCrwjlaxmqXMckX2N7hrj7Wg7Ulu/dQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751660768; a=rsa-sha256; cv=none; b=Xw5/waU0WeXrIsUgZACxny8jtHV6V11CDEyZQJJatM/qs8n1V0q8fMH+/PeCiu6GdCxZYF yCHr6kjvcerY+Vsb3DsGyNfx7mrU2ngncb8vkHz7OcofnbtM7IQobNcTTdCMDYPR9bRKOx mhH5SZrjf8wFoRKDf64Gzv+H+J0WJ0Osvxo3IbwMrHOkgfAAmKqZhrISpOQ/HHIoFBSllz w2kf3pqR6sYJRkzYG+xXwoeImZlTzi3y6nwma7VoBycToFcJlWXCksrBdz9JYZS65AWSlO n+rJgJ1z8jA3v4jNvZJxpHJ8Y9ayZ7EgGPNTg7MHp4pTafyQHjYLUi9Y9SqVCA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bYlX04vvdz155x; Fri, 04 Jul 2025 20:26:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 564KQ8qV096831; Fri, 4 Jul 2025 20:26:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 564KQ8re096828; Fri, 4 Jul 2025 20:26:08 GMT (envelope-from git) Date: Fri, 4 Jul 2025 20:26:08 GMT Message-Id: <202507042026.564KQ8re096828@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 92b352f694e8 - main - gpiobus: gpio_pin_release: convert checks to KASSERTs List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 92b352f694e83827252d42a58df3c6e4dd0e0164 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=92b352f694e83827252d42a58df3c6e4dd0e0164 commit 92b352f694e83827252d42a58df3c6e4dd0e0164 Author: Ahmad Khalifa AuthorDate: 2025-07-04 20:02:57 +0000 Commit: Ahmad Khalifa CommitDate: 2025-07-04 20:24:31 +0000 gpiobus: gpio_pin_release: convert checks to KASSERTs Reviewed by: mmel, imp Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D50868 --- sys/dev/gpio/gpiobus.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/dev/gpio/gpiobus.c b/sys/dev/gpio/gpiobus.c index e919561340a8..c28fac66115b 100644 --- a/sys/dev/gpio/gpiobus.c +++ b/sys/dev/gpio/gpiobus.c @@ -218,15 +218,13 @@ gpio_pin_release(gpio_pin_t gpio) { device_t busdev; - if (gpio == NULL) - return; - + KASSERT(gpio != NULL, ("GPIO pin is NULL.")); KASSERT(gpio->dev != NULL, ("GPIO pin device is NULL.")); busdev = GPIO_GET_BUS(gpio->dev); - if (busdev != NULL) - gpiobus_release_pin(busdev, gpio->pin); + KASSERT(busdev != NULL, ("gpiobus dev is NULL.")); + gpiobus_release_pin(busdev, gpio->pin); free(gpio, M_DEVBUF); }