From owner-cvs-src-old@FreeBSD.ORG Tue Jan 26 03:42:42 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B431F1065676 for ; Tue, 26 Jan 2010 03:42:41 +0000 (UTC) (envelope-from neel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5C4278FC13 for ; Tue, 26 Jan 2010 03:42:41 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o0Q3gfsP072480 for ; Tue, 26 Jan 2010 03:42:41 GMT (envelope-from neel@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o0Q3gfw5072479 for cvs-src-old@freebsd.org; Tue, 26 Jan 2010 03:42:41 GMT (envelope-from neel@repoman.freebsd.org) Message-Id: <201001260342.o0Q3gfw5072479@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to neel@repoman.freebsd.org using -f From: Neel Natu Date: Tue, 26 Jan 2010 03:42:34 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/cfe cfe_console.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 03:42:42 -0000 neel 2010-01-26 03:42:34 UTC FreeBSD src repository Modified files: sys/dev/cfe cfe_console.c Log: SVN rev 203001 on 2010-01-26 03:42:34Z by neel Create the "cfecons" tty directly using tty_makedev(). It is not clear what the intention of having two ttys pointing to the same cfe console device was. Also we were not initializing the output[] array passed in as input to tty_makedev() so one name of the ttys was garbage. Fix the code that calls cfe_write() to deal with the case where only a partial buffer is written out. cfe_cngetc() needs to return if there is no character available as input. If we don't do this then the cfe_timeout() function will spin forever because cfe_cngetc() will only ever return if there is valid input. Approved by: imp (mentor) Revision Changes Path 1.8 +11 -11 src/sys/dev/cfe/cfe_console.c