From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jun 22 16:00:10 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ACEF31065670 for ; Fri, 22 Jun 2012 16:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 770818FC1B for ; Fri, 22 Jun 2012 16:00:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5MG0A1t000288 for ; Fri, 22 Jun 2012 16:00:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5MG0A5T000286; Fri, 22 Jun 2012 16:00:10 GMT (envelope-from gnats) Resent-Date: Fri, 22 Jun 2012 16:00:10 GMT Resent-Message-Id: <201206221600.q5MG0A5T000286@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan McGregor Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C4C0C106564A for ; Fri, 22 Jun 2012 15:52:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 9668B8FC12 for ; Fri, 22 Jun 2012 15:52:42 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5MFqghA007280 for ; Fri, 22 Jun 2012 15:52:42 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q5MFqgfv007279; Fri, 22 Jun 2012 15:52:42 GMT (envelope-from nobody) Message-Id: <201206221552.q5MFqgfv007279@red.freebsd.org> Date: Fri, 22 Jun 2012 15:52:42 GMT From: Dan McGregor To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/169328: net/avahi-app unconditionally overwrites modified configuration files X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2012 16:00:10 -0000 >Number: 169328 >Category: ports >Synopsis: net/avahi-app unconditionally overwrites modified configuration files >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jun 22 16:00:09 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Dan McGregor >Release: 9.0-STABLE >Organization: >Environment: FreeBSD shadrach.dyndns.org 9.0-STABLE FreeBSD 9.0-STABLE #0 r237403M: Thu Jun 21 13:14:23 CST 2012 dan@shadrach.dyndns.org:/usr/obj/usr/src/sys/SHADRACH amd64 >Description: This may well be an upstream bug, but when performing a make reinstall or make install of avahi-app the configuration files avahi-daemon and hosts are installed in $LOCALBASE/etc/avahi, even if the files already exist. The relevant lines of the build log are: test -z "/usr/local/etc/avahi" || .././install-sh -c -d "/usr/local/etc/avahi" install -o root -g wheel -m 444 avahi-daemon.conf hosts '/usr/local/etc/avahi' gmake[1] : on quitte le répertoire « /usr/obj/usr/ports/net/avahi-app/work/avahi-0.6.29/avahi-daemon » Later on in the install it installs them conditionally (this is after the gmake install phase): install -o root -g wheel -m 444 /usr/obj/usr/ports/net/avahi-app/work/avahi-0.6.29/avahi-daemon/hosts /usr/local/etc/avahi/hosts.dist if [ ! -f /usr/local/etc/avahi/hosts ]; then install -o root -g wheel -m 444 /usr/obj/usr/ports/net/avahi-app/work/avahi-0.6.29/avahi-daemon/hosts /usr/local/etc/avahi; fi install -o root -g wheel -m 444 /usr/obj/usr/ports/net/avahi-app/work/avahi-0.6.29/avahi-daemon/avahi-daemon.conf /usr/local/etc/avahi/avahi-daemon.conf.dist if [ ! -f /usr/local/etc/avahi/avahi-daemon.conf ]; then install -o root -g wheel -m 444 /usr/obj/usr/ports/net/avahi-app/work/avahi-0.6.29/avahi-daemon/avahi-daemon.conf /usr/local/etc/avahi; fi This makes upgrades awkward. >How-To-Repeat: Install net/avahi-app edit $LOCALBASE/etc/avahi/hosts or avahi-daemon.conf upgrade net/avahi-app cd $LOCALBASE/etc/avahi diff hosts.dist hosts diff avahi-daemon.conf.dist avahi-daemon.conf >Fix: I suggest we disable installing config files in the gmake install phase and only perform the latter. I don't know enough about autotools though to know how to do that. >Release-Note: >Audit-Trail: >Unformatted: