From owner-p4-projects@FreeBSD.ORG  Sat Feb  2 02:40:52 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id ECE1016A477; Sat,  2 Feb 2008 02:40:51 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8AEC816A46D
	for <perforce@FreeBSD.org>; Sat,  2 Feb 2008 02:40:51 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D85E13C468
	for <perforce@FreeBSD.org>; Sat,  2 Feb 2008 02:40:51 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 9D6931A4D82; Fri,  1 Feb 2008 18:22:34 -0800 (PST)
Date: Fri, 1 Feb 2008 18:22:34 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
Message-ID: <20080202022234.GR99258@elvis.mu.org>
References: <200712020001.lB201XbN000811@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200712020001.lB201XbN000811@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 129920 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Feb 2008 02:40:52 -0000

This change makes very little sense.  If xfer->frbuffers is a bare
pointer, then why add 0 to it?  Just pass xfer->frbuffers or use a
macro that explains what you are doing.

* Hans Petter Selasky <hselasky@FreeBSD.org> [071201 16:01] wrote:
> http://perforce.freebsd.org/chv.cgi?CH=129920
> 
> Change 129920 by hselasky@hselasky_laptop001 on 2007/12/02 00:00:47
> 
> 	
> 	"buf_data" will be removed and replaced by "frbuffers + 0".
> 
> Affected files ...
> 
> .. //depot/projects/usb/src/sys/dev/usb/usb_compat_linux.c#12 edit
> 
> Differences ...
> 
> ==== //depot/projects/usb/src/sys/dev/usb/usb_compat_linux.c#12 (text+ko) ====
> 
> @@ -1286,7 +1286,7 @@
>  				uipd = urb->iso_frame_desc + x;
>  				uipd->actual_length = xfer->frlengths[x];
>  				uipd->status = 0;
> -				usbd_copy_out(&(xfer->buf_data), offset,
> +				usbd_copy_out(xfer->frbuffers + 0, offset,
>  				    ((uint8_t *)(urb->transfer_buffer)) + uipd->offset,
>  				    uipd->actual_length);
>  				offset += max_frame;
> @@ -1354,7 +1354,7 @@
>  			for (x = 0; x < urb->number_of_packets; x++) {
>  				uipd = urb->iso_frame_desc + x;
>  				xfer->frlengths[x] = uipd->length;
> -				usbd_copy_in(&(xfer->buf_data), offset,
> +				usbd_copy_in(xfer->frbuffers + 0, offset,
>  				    ((uint8_t *)(urb->transfer_buffer)) + uipd->offset,
>  				    uipd->length);
>  				offset += uipd->length;

-- 
- Alfred Perlstein