From nobody Sat Apr 26 18:12:04 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZlHq85k0hz5tYgd; Sat, 26 Apr 2025 18:12:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZlHq82PC7z43Fy; Sat, 26 Apr 2025 18:12:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745691124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uIneZjzZzxsuRLa3NSMjJTh2ES1PGiGyZ9b7YheJyAI=; b=op/YtaY0Cbgw2GEJ7EZkmZ1DEx88ljoT9A+QYXF1q2/yU/jpqYxoJEX/ReQRgNfB6MZNIy NdjEhi94wRE58zrCCrSQ4rGugKXo1BNqRAsEhQkIfXR+RP5wtlPY1JWrI3VnMhWfjXoDaC NvR9OrG+/Na5Dvme5DM4lIiBSYdTjqX7LAVC6jpzRRg5NtAKCHg28jUOZ2TnE8yTl+IKZV TXMCZRVKFqCDrME0QxMXVloPTIRU6gHKhLZDvMKQc7N7YVZj/Ca2SUNu/I5P1Anpr+5Tix L0gRQz2nAK+urZm3xZwpsAi2wOake08GTfOWjfktpvzG9Ir59nWxIeRdTTiQEg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745691124; a=rsa-sha256; cv=none; b=g+9FMmMaCr9NSXmEVZLV1CLyJjdBKBgh5rI4qWoxl6B3353z8XmmLm98DOP/xrU7SlR7aV skEHHfSAl1paOHlrzxCIRJfQ9eSzcxMseKLeOGwj97ruZRlxZhapjhe1PTBY01RM9GyU+8 WEQFlpc5V6QM8+4h9tD79BcKfFQH5qQ6eKNWNiYaA5wVAMoL0kQ7VgT9MqQPUqkVF9UPrz cVWlGXhjyesxDn0J8ywQY0QFEz0CDAKyfBt/QZVkW5Sa/6IcAlWvohU3kTCrYpETt9sycM xjI3Y37SRpDnNysXsqw3uHCtn82CLYKC3Y2THhoahcGnserKdIpQcZzjfgRn6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745691124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uIneZjzZzxsuRLa3NSMjJTh2ES1PGiGyZ9b7YheJyAI=; b=TxiYt5+5OAfJphDzM94ksv6AFHp7dWJgm4+3PWVHAkbuWTHPMSwchl59GhBoYXemGmIt2j +ZT8LnksCVD+u1hPKdgbSGOWS+cfmH+yw94v+exeOM6vkUr5WUq1nj4JedUYD39kYz7TWj Cc4La10/AkjH9JJeXJM5EGNW28eOZZwJNuUKNKBskzLjzRLvlqn71yZrp90lOgR0pMNVOf H4asLKQFAzWJATOp+DHvVNjBVrTe63dw03zO1Z/akRgyXk3j2MdRG2MGAYME0gC2kOA+QB ZlX+urxM5jKBNYGGaxA3aX9L+s1HM5OiisBcCEa5o6Q7n5GCDjfBLHwd+DANXQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZlHq820D5zXMX; Sat, 26 Apr 2025 18:12:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53QIC4Tj082452; Sat, 26 Apr 2025 18:12:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53QIC4IB082449; Sat, 26 Apr 2025 18:12:04 GMT (envelope-from git) Date: Sat, 26 Apr 2025 18:12:04 GMT Message-Id: <202504261812.53QIC4IB082449@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Doug Moore Subject: git: ce3f5e979d42 - main - vm_fault: use iterators in dontneed() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ce3f5e979d42deb9268774c9660d5599e4349c15 Auto-Submitted: auto-generated The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=ce3f5e979d42deb9268774c9660d5599e4349c15 commit ce3f5e979d42deb9268774c9660d5599e4349c15 Author: Doug Moore AuthorDate: 2025-04-26 18:08:01 +0000 Commit: Doug Moore CommitDate: 2025-04-26 18:08:01 +0000 vm_fault: use iterators in dontneed() Use iterators instead of tailq pointers in vm_fault_dontneed(). Reviewed by: alc Differential Revision: https://reviews.freebsd.org/D50012 --- sys/vm/vm_fault.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c index 8531dc9d5196..36e6e7d50513 100644 --- a/sys/vm/vm_fault.c +++ b/sys/vm/vm_fault.c @@ -1853,11 +1853,11 @@ found: static void vm_fault_dontneed(const struct faultstate *fs, vm_offset_t vaddr, int ahead) { + struct pctrie_iter pages; vm_map_entry_t entry; vm_object_t first_object; vm_offset_t end, start; - vm_page_t m, m_next; - vm_pindex_t pend, pstart; + vm_page_t m; vm_size_t size; VM_OBJECT_ASSERT_UNLOCKED(fs->object); @@ -1876,13 +1876,12 @@ vm_fault_dontneed(const struct faultstate *fs, vm_offset_t vaddr, int ahead) else start = end - size; pmap_advise(fs->map->pmap, start, end, MADV_DONTNEED); - pstart = OFF_TO_IDX(entry->offset) + atop(start - - entry->start); - m_next = vm_page_find_least(first_object, pstart); - pend = OFF_TO_IDX(entry->offset) + atop(end - - entry->start); - while ((m = m_next) != NULL && m->pindex < pend) { - m_next = TAILQ_NEXT(m, listq); + vm_page_iter_limit_init(&pages, first_object, + OFF_TO_IDX(entry->offset) + + atop(end - entry->start)); + VM_RADIX_FOREACH_FROM(m, &pages, + OFF_TO_IDX(entry->offset) + + atop(start - entry->start)) { if (!vm_page_all_valid(m) || vm_page_busied(m)) continue;