From owner-dev-commits-src-main@freebsd.org Sun Jan 17 14:18:34 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E4B2C4EACDD; Sun, 17 Jan 2021 14:18:34 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DJcTk1grkz3G8h; Sun, 17 Jan 2021 14:18:33 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1610893111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kvDZyQAavmbk2zhTzqb4vV5HiorlNnbg0C9FKEFC94=; b=rQDNBRM4wJnCNNvKzOCSHvz4id+tVigLPU/w2xdx/AlxCsJkvFZtdlsBfdPPGTtUzsB2f1 CGIqbCTLsQxxvLtZCr3wwTooQPWMbqvwig8iE256md1X0Ext/A35G6AV7WXCaqRT0ULrEq TFJyXNCRYzh9LNjEdLac9V8+u2DHXeQ= Received: from amy.home (lfbn-idf2-1-745-114.w86-247.abo.wanadoo.fr [86.247.192.114]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 81734850 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 17 Jan 2021 14:18:31 +0000 (UTC) Date: Sun, 17 Jan 2021 15:18:31 +0100 From: Emmanuel Vadot To: rgrimes@freebsd.org Cc: "Rodney W. Grimes" , Stefan Esser , Gleb Smirnoff , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7e4eca7136ea - main - Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on remote filesystems. Discussed this with Brooks and he can't find evidence that provoked the change in 2005. If anything gets broken I will fix it in a dif Message-Id: <20210117151831.25facacac2d981df4b0ab54e@bidouilliste.com> In-Reply-To: <202101171403.10HE32Vc058085@gndrsh.dnsmgr.net> References: <3a7b249e-3a5b-d237-882d-508f7784c75b@freebsd.org> <202101171403.10HE32Vc058085@gndrsh.dnsmgr.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DJcTk1grkz3G8h X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2021 14:18:35 -0000 Hi Rod, Could you please fix your mailer, those issues have been buging me for years : On Sun, 17 Jan 2021 06:03:02 -0800 (PST) "Rodney W. Grimes" wrote: > -- Start of PGP signed section. > [ Charset windows-1252 ignored, treated as US-ASCII ] I don't know why those lines are inserted, especially since your mail isn't pgp signed. > > Am 17.01.21 um 04:18 schrieb Rodney W. Grimes: Since your mailer doesn't add a quote introduction it always looks like that you're replying to the previous mail (and here it looks like you're replying to yourself). > > >> The branch main has been updated by glebius: > > >> > > >> URL: https://cgit.FreeBSD.org/src/commit/?id=7e4eca7136eaa35e15f67682468f09aa7127b543 > > >> > > >> commit 7e4eca7136eaa35e15f67682468f09aa7127b543 > > >> Author: Gleb Smirnoff > > >> AuthorDate: 2021-01-11 20:13:41 +0000 > > >> Commit: Gleb Smirnoff > > >> CommitDate: 2021-01-15 20:44:06 +0000 > > >> > > >> Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on > > >> remote filesystems. Discussed this with Brooks and he can't find > > >> evidence that provoked the change in 2005. If anything gets broken > > >> I will fix it in a different way, not via rc sequence change. > > > > > > This is because /etc/rc.d/tmp has this line: > > > if ! /bin/df /tmp | grep -q "^/dev/md[0-9].* /tmp"; then > > > > > > and when your doing NFS boots with seperate /usr you do not have > > > /usr/bin/grep to run that line. > > > > > > Almost always the reason things have a REQUIRE: mountcritremote > > > is that they use some commands from /usr. > > Critical statement, :"some commands": you fixed 1 of them, > I also so a bit later: > if _tmpdir=$(mktemp -d -q /tmp/.diskless.XXXXXX); then > > mktemp lives in /usr/bin also > > > This dependency on /usr/bin/grep is easily removed, see: > > > > https://reviews.freebsd.org/D28209 > > > > I like this fix, less dependance on /usr during boot > processing is good. > > > diff --git a/libexec/rc/rc.d/tmp b/libexec/rc/rc.d/tmp > > index a61321e058ee..2a7205e92b59 100755 > > --- a/libexec/rc/rc.d/tmp > > +++ b/libexec/rc/rc.d/tmp > > @@ -40,10 +40,16 @@ load_rc_config $name > > > > mount_tmpmfs() > > { > > - if ! /bin/df /tmp | grep -q "^/dev/md[0-9].* /tmp"; then > > - mount_md ${tmpsize} /tmp "${tmpmfs_flags}" > > - chmod 01777 /tmp > > - fi > > + while read line; do > > + case $line in > > + /dev/md[0-9]*\ /tmp) > > + return;; > > + esac > > + done <<*EOF > > +$(df /tmp) > > +*EOF > > + mount_md ${tmpsize} /tmp "${tmpmfs_flags}" > > + chmod 01777 /tmp > > } > > > > # If we do not have a writable /tmp, create a memory > > > -- End of PGP section, PGP failed! See, not pgp signed. Cheers, > -- > Rod Grimes rgrimes@freebsd.org -- Emmanuel Vadot