From owner-freebsd-arch Wed Nov 29 11:48:30 2000 Delivered-To: freebsd-arch@freebsd.org Received: from palrel3.hp.com (palrel3.hp.com [156.153.255.226]) by hub.freebsd.org (Postfix) with ESMTP id 62EA037B699 for ; Wed, 29 Nov 2000 11:48:28 -0800 (PST) Received: from adlmail.cup.hp.com (adlmail.cup.hp.com [15.0.100.30]) by palrel3.hp.com (Postfix) with ESMTP id 2B4BF37E; Wed, 29 Nov 2000 11:48:27 -0800 (PST) Received: from cup.hp.com (p1000180.nsr.hp.com [15.109.0.180]) by adlmail.cup.hp.com (8.9.3 (PHNE_18546)/8.9.3 SMKit7.02) with ESMTP id LAA17261; Wed, 29 Nov 2000 11:48:26 -0800 (PST) Message-ID: <3A255D8A.7F5CFB26@cup.hp.com> Date: Wed, 29 Nov 2000 11:48:26 -0800 From: Marcel Moolenaar Organization: Hewlett-Packard X-Mailer: Mozilla 4.73 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Daniel Eischen Cc: Alfred Perlstein , arch@FreeBSD.ORG Subject: Re: Modifying FILE to add lock References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Daniel Eischen wrote: > > > I have no objection as long as you bump the shared lib version > > from -stable. This would be a great time to do it. > > This would only be in -current (where the library versions have > already been bumped) and for our new libpthread. I agree. We should not MFC this. Library version bumps halfway on a -stable branch doesn't seem appropriate. Changing structures is not done, IMO. Anyway: In stdio.h I'm told that I should read the warning before changing the layout of struct __sFILE. There doesn't seem to be a warning anywhere in the header file, so I figure it must be the long comment before the struct declaration. The comment doesn't tell me what happens if I change the layout. It only tells me what certain fields are for and doesn't mention _offset at all, even though that field specifically references the warning. My point: We're hinted to be careful and cautious without actually being told why. Can someone tell me what problems we might expect if we add a new field, both specifically at the end and randomly within the structure? -- Marcel Moolenaar mail: marcel@cup.hp.com / marcel@FreeBSD.org tel: (408) 447-4222 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message