From nobody Sat Mar 28 07:51:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fjV8C1Mtlz6W3gm for ; Sat, 28 Mar 2026 07:51:39 +0000 (UTC) (envelope-from mail@fbsd2.e4m.org) Received: from mail.e4m.org (mail.e4m.org [IPv6:2a03:4000:66:f68::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.e4m.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fjV8B2Z18z45GC for ; Sat, 28 Mar 2026 07:51:38 +0000 (UTC) (envelope-from mail@fbsd2.e4m.org) Authentication-Results: mx1.freebsd.org; none ARC-Filter: OpenARC Filter v1.0 mail.e4m.org 62S7pPcl047951 ARC-Seal: i=1; d=e4m.org; s=s; a=rsa-sha256; cv=none; t=1774684286; b=VrtjzrfhhTo8vOHVt8fi2+oMpyndfuWpHBhpO8luDbRDyxOyMSd1KhCOJqoKSySjYf5d qy2W4Qetjc6vNZ39BeZHKtAXkfcuIg41XWcJ3B/wY9DkznGB//dPcj9pJY+2loi5t0Bia 5IGxbvCE5yAdswuWnECnzd5s1syrvo9aak4m73WUNrP+BQbiu2ZTjSW1gT5F/mnXPECKH wYj2icto6hvMlYOscvE76Zxwh4c6EleSAa4v4Srg4I4RQ2YtFfzWn4sPdHQBNg/sAzw7c wBc+p1/uzhEk4Z7kFmYqTiNi9UgOcueVm+Q6YscT5t1DO6hcTTVizx4bCy1vuFJnmqw== ARC-Message-Signature: i=1; d=e4m.org; s=s; a=rsa-sha256; c=relaxed/relaxed; t=1774684286; h=DKIM-Filter:DKIM-Signature:Received:Received:Received:Date:From:To: Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:In-Reply-To; bh=Vcdlnm64R3TO/YQIrJlz6JAJ07W1lQN8/MmUc82dTVM=; b=hjwR4brihmVybEwVWADugAxK1Hyo3p/R39e2C4YsyhPhkDQ40/5w23xAUVqiVDXPd3Vd xNm4G62F/aaPfSIYbx2r2/NNisB7nVHSnSoEJSZb6tTjcIS7l4P3y9pRCp3vsoO7WHhR5 O1xQGNB05BCtJqkwBdmBT2iydq/DY48m3az9FHPRmW+NNp+bRDkN4rb0FcIDWtiR1/F/S QElxvwx39De9QGEklupx+hZ/A6PW2JQn5v5tWZoiYUI4woC3GmeH9Q0tLlx32K3pPfgsY Rdqwxj61XK0lXcSv+T+Q+V377pHjsboMEY6bwi+DKk39zZVht6I9Qm+BBhQwhTmyZ6w== ARC-Authentication-Results: i=1; mail.e4m.org; arc=none smtp.remote-ip="2a02:3100:9208:e782:ec4:7aff:fee6:add0" DKIM-Filter: OpenDKIM Filter v1.0 mail.e4m.org 62S7pPcl047951 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=e4m.org; s=s; t=1774684286; i=@e4m.org; bh=Vcdlnm64R3TO/YQIrJlz6JAJ07W1lQN8/MmUc82dTVM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:Date:From:To: Subject:Reply-to:Cc:In-reply-to:References; b=BOITnAw7l/qCmmfrzGbjhi4JAwrjHZXQHCZSpMbvLc+JfXc3duLNWNTjFR3glpziC slenSA5OAiPlCU6H692SrxXz6qZQdLd7aL8maJJrgRs/YY4a6CYc1V/Yp2O1LQZjMF 5jSLNjHMgRJicCB3LKurWtwg+NyPE0qMGKvbfnwm17Zr7AMsZa6+26IbfBX7oVbJkB nuVTyjFH0Uwk11KTrhDMAKTmY9cJBbU9h6pyyfq6XU11wc2UGXZp1qPCD6aUMmd7Us 1cw5a5IPe9nFMeoXwoUPT5SisStl4yd72iZ0UEWpzD348EQq03vHGNNxzmv4qJziMj 0nZOkl0Pdotjg== Received: from dynamic-2a02-3100-9208-e782-0ec4-7aff-fee6-add0.310.pool.telefonica.de (dynamic-2a02-3100-9208-e782-0ec4-7aff-fee6-add0.310.pool.telefonica.de [IPv6:2a02:3100:9208:e782:ec4:7aff:fee6:add0]) (authenticated bits=128) by mail.e4m.org (8.18.1/8.18.1) with ESMTPSA id 62S7pPcl047951 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=FAIL); Sat, 28 Mar 2026 08:51:26 +0100 (CET) (envelope-from mail@fbsd2.e4m.org) Received: from stationary.client ([IPv6:fd00:0:0:0:0:0:0:3]) by gate.local (8.18.1/8.18.1) with ESMTPS id 62S7pJeH090230 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 28 Mar 2026 08:51:20 +0100 (CET) (envelope-from mail@fbsd2.e4m.org) Received: from submit.client ([127.0.0.1]) by voyager.local (8.18.1/8.18.1) with ESMTP id 62S7pJbO005205; Sat, 28 Mar 2026 08:51:19 +0100 (CET) (envelope-from mail@fbsd2.e4m.org) Received: (from user@localhost) by voyager.local (8.18.1/8.18.1/Submit) id 62S7pJtI005204; Sat, 28 Mar 2026 08:51:19 +0100 (CET) (envelope-from mail@fbsd2.e4m.org) Date: Sat, 28 Mar 2026 08:51:19 +0100 From: Andre Albsmeier To: Warner Losh Cc: Andre Albsmeier , Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: Removing stuff from NOTES because it is in GENEREIC Message-ID: References: <695c68c6.3ff5d.593fc2c7@gitrepo.freebsd.org> <86ldfeyggv.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:197540, ipnet:2a03:4000::/32, country:DE] X-Rspamd-Queue-Id: 4fjV8B2Z18z45GC X-Spamd-Bar: ---- On Fri, 27-Mar-2026 at 22:33:46 -0600, Warner Losh wrote: > On Fri, Mar 27, 2026 at 2:54 AM Andre Albsmeier wrote: > > > On Thu, 26-Mar-2026 at 12:31:44 +0100, Dag-Erling Smørgrav wrote: > > > Andre Albsmeier writes: > > > > Is it correct to remove something from NOTES because it is in GENERIC? > > > > > > > > My impression was that NOTES contains ALL what can be configured into > > > > a kernel (whether it makes sense or not). Am I wrong here? > > > > > > You are correct. NOTES is intended to have all options that can be > > > enabled, plus non-default values for all parameters that can be tuned. > > > > OK, thanks to you and Warner for clarifying. > > > > When checking sys/amd64/conf/GENERIC on -HEAD, I found the following > > items which are not in sys/{.,x86,amd64}/conf/NOTES: > > > > device ocs_fc > > device tws > > device ufshci > > device aq > > device vge > > > > These are needed. I'll commit. > > > > option EXTERR_STRINGS > > option IPSEC_OFFLOAD > > option FIB_ALGO > > option PRINTF_BUFR_SIZE > > option KDTRACE_FRAME > > option DDB_CTF > > option RACCT_DEFAULT_TO_DISABLED > > option AH_AR5416_INTERRUPT_MITIGATION > > > > Should they be added? > > > > These are in GENERIC and not LINT, so we get things done both ways. Sorry, I don't understand entirely. Most options we find in GENERIC are also in one of the NOTES. So why shouldn't those above not be included as well? Or, in other words: Why, just as an example, do we have options IEEE80211_DEBUG options IEEE80211_SUPPORT_MESH options USB_DEBUG in NOTES when they are already in GENERIC? -Andre