From owner-svn-ports-head@freebsd.org Thu Oct 13 14:59:47 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A731BC0E6E0 for ; Thu, 13 Oct 2016 14:59:47 +0000 (UTC) (envelope-from kmoore@freebsd.org) Received: from barracuda.ixsystems.com (barracuda.ixsystems.com [12.229.62.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.ixsystems.com", Issuer "Go Daddy Secure Certificate Authority - G2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 89428AA8 for ; Thu, 13 Oct 2016 14:59:47 +0000 (UTC) (envelope-from kmoore@freebsd.org) X-ASG-Debug-ID: 1476370786-08ca0410a15f4c0001-7kGxFj Received: from zimbra.ixsystems.com ([10.246.0.20]) by barracuda.ixsystems.com with ESMTP id EMZvaNX1K2Mc5gXe (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 13 Oct 2016 07:59:46 -0700 (PDT) X-Barracuda-Envelope-From: kmoore@freebsd.org X-ASG-Whitelist: Sender X-Barracuda-RBL-Trusted-Forwarder: 10.246.0.20 X-ASG-Whitelist: Client Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id CE1DF8FE344; Thu, 13 Oct 2016 07:59:46 -0700 (PDT) Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Bd8909NsRkeK; Thu, 13 Oct 2016 07:59:46 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id 6D4508FE345; Thu, 13 Oct 2016 07:59:46 -0700 (PDT) X-Virus-Scanned: amavisd-new at ixsystems.com Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id lk56m_b1j9Q3; Thu, 13 Oct 2016 07:59:46 -0700 (PDT) Received: from [192.168.0.150] (75-130-56-30.static.kgpt.tn.charter.com [75.130.56.30]) by zimbra.ixsystems.com (Postfix) with ESMTPSA id D53238FE344; Thu, 13 Oct 2016 07:59:45 -0700 (PDT) Subject: Re: svn commit: r423922 - in head/security: . ngrok To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-ASG-Orig-Subj: Re: svn commit: r423922 - in head/security: . ngrok References: <201610131431.u9DEVcA7079532@repo.freebsd.org> <773bb4e0-00d2-6234-33ae-fdafce1135a7@FreeBSD.org> From: Kris Moore Organization: FreeBSD Project Message-ID: Date: Thu, 13 Oct 2016 10:59:44 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <773bb4e0-00d2-6234-33ae-fdafce1135a7@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Barracuda-Connect: UNKNOWN[10.246.0.20] X-Barracuda-Start-Time: 1476370786 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://10.246.0.26:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ixsystems.com X-Barracuda-BRTS-Status: 1 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 14:59:47 -0000 On 10/13/2016 10:42, Mathieu Arnold wrote: > Le 13/10/2016 =C3=A0 16:31, Kris Moore a =C3=A9crit : >> +PORTNAME=3D ngrok >> +PORTVERSION=3D 2.1.14 >> +CATEGORIES=3D security >> +MASTER_SITES=3D https://bin.equinox.io/c/4VmDzA7iaHb/ >> +DISTNAME=3D ${PORTNAME}-stable-freebsd-${NGROK_ARCH} >> > The DISTNAME seems to not have PORTVERSION in it. It means that when th= e > software is updated, there will be a second distfile with the same name= , > which is a bad thing. For those case, you should add: > > DIST_SUBDIR=3D ${PORTNAME}/${PORTVERSIONS} > > or something, so that there cannot be two different files with the same > name. > > Good catch! I've added that now.