From owner-freebsd-ipfw@FreeBSD.ORG  Wed Mar 24 23:21:03 2010
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3418F106566B
	for <freebsd-ipfw@freebsd.org>; Wed, 24 Mar 2010 23:21:03 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
	by mx1.freebsd.org (Postfix) with ESMTP id EE26C8FC1D
	for <freebsd-ipfw@freebsd.org>; Wed, 24 Mar 2010 23:21:02 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id 61D00730A1; Thu, 25 Mar 2010 00:30:55 +0100 (CET)
Date: Thu, 25 Mar 2010 00:30:55 +0100
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Michael Sierchio <kudzu@tenebras.com>
Message-ID: <20100324233055.GC37533@onelab2.iet.unipi.it>
References: <hoe0o3$lek$1@dough.gmane.org>
	<813887681003241522r3e124c43m2c0dd2a3d280da08@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <813887681003241522r3e124c43m2c0dd2a3d280da08@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-ipfw@freebsd.org, Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
Subject: Re: ipfw: missing action
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2010 23:21:03 -0000

On Wed, Mar 24, 2010 at 03:22:40PM -0700, Michael Sierchio wrote:
> I'm really distressed about the state of ipfw development.  Is there no test
> harness?  Rather than becoming more mature and stable, I think it's in the
> weeds these days.

Yeah, really disgusting :)

I am sorry, there is no comprehensive test harness.  Various parts
of this code have been in HEAD for 1 to 3 months, and i got 0 reports
there. Within two days of the merge we got reports for 3 (trivial)
bugs, which were fixed in a matter of hours. I'd love if all of our
bugs were like this.

cheers
luigi

> - M
> 
> On Wed, Mar 24, 2010 at 2:38 PM, Marcin Wisnicki <
> mwisnicki+freebsd@gmail.com <mwisnicki%2Bfreebsd@gmail.com>> wrote:
> 
> > Another victim of recent MFC:
> >
> > # ipfw -n add 00100 set 2 allow all from any to any via lo0
> > ipfw: missing action
> >
> > Bug also exists on head.
> > Someone should add "write IPFW testsuite" to FreeBSD project ideas ;)
> >
> > diff -ruN /usr/src/sbin/ipfw/ipfw2.c /home/marcin/p/bugfix/ipfw/ipfw2.c
> > --- /usr/src/sbin/ipfw/ipfw2.c  2010-03-24 04:19:34.000000000 +0100
> > +++ /home/marcin/p/bugfix/ipfw/ipfw2.c  2010-03-24 22:07:33.000000000 +0100
> > @@ -2656,7 +2656,7 @@
> >        }
> >
> >        /* [set N]      -- set number (0..RESVD_SET), optional */
> > -       if (av[0] && !av[1] && _substrcmp(*av, "set") == 0) {
> > +       if (av[0] && av[1] && _substrcmp(*av, "set") == 0) {
> >                int set = strtoul(av[1], NULL, 10);
> >                if (set < 0 || set > RESVD_SET)
> >                        errx(EX_DATAERR, "illegal set %s", av[1]);
> >
> > _______________________________________________
> > freebsd-ipfw@freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
> > To unsubscribe, send any mail to "freebsd-ipfw-unsubscribe@freebsd.org"
> >
> _______________________________________________
> freebsd-ipfw@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
> To unsubscribe, send any mail to "freebsd-ipfw-unsubscribe@freebsd.org"