From nobody Wed Apr 30 17:21:35 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZnkW45VZ7z5thmC; Wed, 30 Apr 2025 17:21:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZnkW406bSz3Lxg; Wed, 30 Apr 2025 17:21:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746033696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rTjOlODVzLHtYbpy39ZRNCRLGd+ckkllv2bHVTE4BMI=; b=l37Pyk3aWK2x2CCQZtuAN5r8FSk0HiBzvwLE/1hP2i6kney0rxnFJ0fqa2DJXsD326n3HW ntJuIsyyqBEO9+VtMMPRv+oGS5Tx2KpvhUDYZinkjlq8+sDASJbIVbKtp2YyM/koi1eTgQ UwyWSNsnW+LMsIpaYtVYBa6lcrrTRdqF2ucdy++wi7MCwTjm5WpVx7iXd/nzkemAhf5ZaL vvYjTQ1aYSs4D2SZIX0PTWSwhXgO0VSEvRn703kTnKbPOQ6QnVrqROFb5izeNHV7Gj5bea 7jqXKE+f6VOB8afQbbO+FM4aVWmq/xtJEHq+/EvL+XxUHILj8urFPJafn23uNg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746033696; a=rsa-sha256; cv=none; b=hLgMKIH1FgmpRMaEjyJ5DCry8Cmtm+ocn0OGVqzMRmyQFxy+0/HLcsvYCVzgMCBgYb4P+b 2u0bIIikbY3fsYnlpn5VPEdcNvQIRXnd1crhK2a/jfIRCkwfmBLXiDTtReibQx3wssmC83 NoyoSSbO5IDBom846nZRBABYdHPC/rfQEXYYnOBqZ6GeFrw8JgurZrjH/WJjxLENjX6i1m y0tomdkLokmIXKWlHOjDaRWHSyYbAqMy10yaaI2MrgPf2T4xPujfgMJmjm2DzekjVUfvC9 v16L3zE6bEtmuU5Sk6nINtZUEHR3xqV6KW18On0tv54gkR7K4TD9pfCQ7Kx5nQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746033696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rTjOlODVzLHtYbpy39ZRNCRLGd+ckkllv2bHVTE4BMI=; b=phKPtr26+I9PIdnNLmxXK6gCk3tQlv8HiAgiF9CdBAkv7P3xuc8XKJVDXZBB/m49CdK6hl O3AnD4J40tAZeGhaI9VZ/06OfXotngwaculF14acajhFygI5A1lVg3urZJ0nP+MN7uzwhl RCeLziNP9v9tbvfvPkllJIBB/CcJc0YAQCYRIuaXPck82k1h7vmm1fTDSV+hSZnMaa+5BP JdzE0enVMsUaOEn+fu2ZSitqvt3QuHFa9a1RxOvx/R2aJjgcf3dbKOz8S17h9+59O55Nne 8c02Ph7lj2jvflTGymLVq+VGA7+qZcHmaUsqLLep6CU6smjXZx9Q0WK/07lsIw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZnkW36rLfzjv; Wed, 30 Apr 2025 17:21:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53UHLZm4093506; Wed, 30 Apr 2025 17:21:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53UHLZVh093503; Wed, 30 Apr 2025 17:21:35 GMT (envelope-from git) Date: Wed, 30 Apr 2025 17:21:35 GMT Message-Id: <202504301721.53UHLZVh093503@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: a24be14366a7 - stable/14 - mpi3mr: Controller state check before enabling PEL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a24be14366a72ed59888e17ba4d05620b9cf36b9 Auto-Submitted: auto-generated The branch stable/14 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=a24be14366a72ed59888e17ba4d05620b9cf36b9 commit a24be14366a72ed59888e17ba4d05620b9cf36b9 Author: Chandrakanth patil AuthorDate: 2024-03-14 17:14:53 +0000 Commit: Warner Losh CommitDate: 2025-04-30 17:05:51 +0000 mpi3mr: Controller state check before enabling PEL Reviewed by: imp Approved by: imp Differential revision: https://reviews.freebsd.org/D44422 (cherry picked from commit 042808f74707d3ce89e89463d4a03f81df6fd45a) --- sys/dev/mpi3mr/mpi3mr_app.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/dev/mpi3mr/mpi3mr_app.c b/sys/dev/mpi3mr/mpi3mr_app.c index f0dee22518a8..811f6e2f08af 100644 --- a/sys/dev/mpi3mr/mpi3mr_app.c +++ b/sys/dev/mpi3mr/mpi3mr_app.c @@ -1642,6 +1642,18 @@ mpi3mr_pel_enable(struct mpi3mr_softc *sc, struct mpi3mr_ioctl_pel_enable pel_enable; mpi3mr_dprint(sc, MPI3MR_TRACE, "%s() line: %d\n", __func__, __LINE__); + if (sc->unrecoverable) { + device_printf(sc->mpi3mr_dev, "Issue IOCTL: controller is in unrecoverable state\n"); + return EFAULT; + } + if (sc->reset_in_progress) { + device_printf(sc->mpi3mr_dev, "Issue IOCTL: reset in progress\n"); + return EAGAIN; + } + if (sc->block_ioctls) { + device_printf(sc->mpi3mr_dev, "Issue IOCTL: IOCTLs are blocked\n"); + return EAGAIN; + } if ((data_out_sz != sizeof(pel_enable) || (pel_enable.pel_class > MPI3_PEL_CLASS_FAULT))) {