Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Feb 2020 19:00:10 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Yuri <yuri@rawbw.com>
Cc:        Piotr Kubaj <pkubaj@anongoth.pl>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r526232 - head/x11-wm/hikari
Message-ID:  <20200216180010.wmck2ge6rf47crm4@atuin.in.mat.cc>
In-Reply-To: <3ac58a2c-ecb7-7614-707e-bb591f29dc23@rawbw.com>
References:  <202002151802.01FI2w9m044102@repo.freebsd.org> <81a9cfc3-f1e2-f506-a5d0-fc95d57686f9@rawbw.com> <20200216104806.GA80117@KGPE-D16> <3ac58a2c-ecb7-7614-707e-bb591f29dc23@rawbw.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--bumnd2cwa4dbta37
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 16, 2020 at 08:16:39AM -0800, Yuri wrote:
> On 2020-02-16 02:48, Piotr Kubaj wrote:
> > Is it necessary even for trivial build fixes?
>=20
>=20
> If this is an unbreak - then you can commit it and 'Approved by' should be
> 'portmgr'.
>=20
> If this is some formatting or trivial fix (license/NO_ARCH/helpers/WWW) -
> then you can commit it and 'Approved by' should be 'portmgr blanket'.
>=20
> Otherwise you should ask the maintainer.
>=20
> But the 'Approved by' line, I think, should always be present when
> MAINTAINER is not you and not ports@

You only use Approved by: someone if someone actually approved the
change you are committing.  Changes that are covered by the blanket
approval do not require any approval, they are not approved by anyone,
they are just authorized to anyone.

--=20
Mathieu Arnold

--bumnd2cwa4dbta37
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl5JgypfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkh5lg/9FYemqgEedXi0K4w13xUQWJaWDzwTtYDuDcZo2u+wU1NU70ddG0ZcebIY
V5OLGuLQBTOj6FNe4pMuhEWWbfTUrMHIRYAJo71P2h4d9/BVTfOrxe9iSZLB7Z6A
1oyMf4W8ERFpSO0t4tqW21C3qYY5S8IEEld88u/79E6cAWKoWLDBX1L++SVzU/u9
FMBPf8I22nK3NizyylBauJmxM7C0KI06LQHj4/ml9EXrJfGFpOMh16X6uNmemB2b
RXh4a//XHPSEKDG4CxosYCL+rJTgd6YgoYECEib/JXD9Smnugn4iZJdYU8zEm8lQ
QOmME1NEYtzOUWmaoITaIFrkC6Ib8gc14lqlvKdgu1cnAMKUnIK/HLRhgIy0IA2M
rzM1gwO03ICYqwBZJoQh45h3/UQTJpXrQSrLzf3ZKrAeXHZWoMfMhBSw9X4tFZXL
qetW/kTauqq0Q55OeHWcHdrzVsQMzjP6oSTs2laIIiCzKfNLYJuVQiNFOF30BsfG
XJ0rbAy1j04et0vNVj75OaBPEBCnvM9sVzf41rQeg/E9bX45P9ONxmmbGnIviE1/
2YQFxeGuioOiN1+6vDb8QBmECYZJlU58hYlsWeqEWa91e8GYrl1TwmaZsv6i9k7f
GIPNEPsnhYocqlQ3QeCVLqgjt7CD0q4y+Xp/bIrU4UTWMYFo8aY=
=uhSh
-----END PGP SIGNATURE-----

--bumnd2cwa4dbta37--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200216180010.wmck2ge6rf47crm4>