From owner-svn-ports-all@freebsd.org Sun Feb 16 18:00:14 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1131023BDE5; Sun, 16 Feb 2020 18:00:14 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48LFJY6fXLz3HSC; Sun, 16 Feb 2020 18:00:13 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id BF3594D18; Sun, 16 Feb 2020 18:00:13 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:94c4:c3e5:da4b:4ed]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 2944E942E97; Sun, 16 Feb 2020 18:00:11 +0000 (UTC) Date: Sun, 16 Feb 2020 19:00:10 +0100 From: Mathieu Arnold To: Yuri Cc: Piotr Kubaj , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r526232 - head/x11-wm/hikari Message-ID: <20200216180010.wmck2ge6rf47crm4@atuin.in.mat.cc> References: <202002151802.01FI2w9m044102@repo.freebsd.org> <81a9cfc3-f1e2-f506-a5d0-fc95d57686f9@rawbw.com> <20200216104806.GA80117@KGPE-D16> <3ac58a2c-ecb7-7614-707e-bb591f29dc23@rawbw.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bumnd2cwa4dbta37" Content-Disposition: inline In-Reply-To: <3ac58a2c-ecb7-7614-707e-bb591f29dc23@rawbw.com> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2020 18:00:14 -0000 --bumnd2cwa4dbta37 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 16, 2020 at 08:16:39AM -0800, Yuri wrote: > On 2020-02-16 02:48, Piotr Kubaj wrote: > > Is it necessary even for trivial build fixes? >=20 >=20 > If this is an unbreak - then you can commit it and 'Approved by' should be > 'portmgr'. >=20 > If this is some formatting or trivial fix (license/NO_ARCH/helpers/WWW) - > then you can commit it and 'Approved by' should be 'portmgr blanket'. >=20 > Otherwise you should ask the maintainer. >=20 > But the 'Approved by' line, I think, should always be present when > MAINTAINER is not you and not ports@ You only use Approved by: someone if someone actually approved the change you are committing. Changes that are covered by the blanket approval do not require any approval, they are not approved by anyone, they are just authorized to anyone. --=20 Mathieu Arnold --bumnd2cwa4dbta37 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl5JgypfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkh5lg/9FYemqgEedXi0K4w13xUQWJaWDzwTtYDuDcZo2u+wU1NU70ddG0ZcebIY V5OLGuLQBTOj6FNe4pMuhEWWbfTUrMHIRYAJo71P2h4d9/BVTfOrxe9iSZLB7Z6A 1oyMf4W8ERFpSO0t4tqW21C3qYY5S8IEEld88u/79E6cAWKoWLDBX1L++SVzU/u9 FMBPf8I22nK3NizyylBauJmxM7C0KI06LQHj4/ml9EXrJfGFpOMh16X6uNmemB2b RXh4a//XHPSEKDG4CxosYCL+rJTgd6YgoYECEib/JXD9Smnugn4iZJdYU8zEm8lQ QOmME1NEYtzOUWmaoITaIFrkC6Ib8gc14lqlvKdgu1cnAMKUnIK/HLRhgIy0IA2M rzM1gwO03ICYqwBZJoQh45h3/UQTJpXrQSrLzf3ZKrAeXHZWoMfMhBSw9X4tFZXL qetW/kTauqq0Q55OeHWcHdrzVsQMzjP6oSTs2laIIiCzKfNLYJuVQiNFOF30BsfG XJ0rbAy1j04et0vNVj75OaBPEBCnvM9sVzf41rQeg/E9bX45P9ONxmmbGnIviE1/ 2YQFxeGuioOiN1+6vDb8QBmECYZJlU58hYlsWeqEWa91e8GYrl1TwmaZsv6i9k7f GIPNEPsnhYocqlQ3QeCVLqgjt7CD0q4y+Xp/bIrU4UTWMYFo8aY= =uhSh -----END PGP SIGNATURE----- --bumnd2cwa4dbta37--