From owner-svn-src-head@FreeBSD.ORG Wed Jun 4 06:10:08 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4EBC2372; Wed, 4 Jun 2014 06:10:08 +0000 (UTC) Received: from mail-wg0-x22a.google.com (mail-wg0-x22a.google.com [IPv6:2a00:1450:400c:c00::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6ED0526F7; Wed, 4 Jun 2014 06:10:07 +0000 (UTC) Received: by mail-wg0-f42.google.com with SMTP id y10so7720362wgg.13 for ; Tue, 03 Jun 2014 23:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=e4lShFZU1O+zs1UedG0cHKDo6pXG67o+AH9gG/1yUZ8=; b=iUAgET5ScKfPzVpmFyLjgC+tk03kt7vzLOsy1wmb2qvMDvHXdlVB+m4fDFspDkNR7c 15iCOPd6n+4kb/0BMtHc5xIzsAHyfInYY7t3hG2XxFmcOEupzl67sy7Z9bI3DbYzKrr8 KBzdz5VvrHXX58qsuoGPBnGcDEI6xYIjHzIOWMZ1kqqhCMsak9s782IN7zuBv1KsZRrL iSAO/78PQQO9u88mVdSKf8YVA76soNFMbvl+zEosOuBLY3Ey/VK6Nlji16H6bHx1oDSu xTqguRE6c+6H4VV/80nlIuOU064uQQzgAQSOXlF7bZEcNojQbeIiY7mMqDYLM1b7voVg 71Ew== X-Received: by 10.15.102.74 with SMTP id bq50mr3465940eeb.4.1401862205608; Tue, 03 Jun 2014 23:10:05 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by mx.google.com with ESMTPSA id m2sm3218106eey.36.2014.06.03.23.10.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Jun 2014 23:10:05 -0700 (PDT) Sender: Alexander Motin Message-ID: <538EB83B.70700@FreeBSD.org> Date: Wed, 04 Jun 2014 09:10:03 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r267029 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs References: <201406032106.s53L63oR085624@svn.freebsd.org> <538EA8E4.1070300@FreeBSD.org> In-Reply-To: <538EA8E4.1070300@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2014 06:10:08 -0000 On 04.06.2014 08:04, Bryan Drewery wrote: > On 6/3/2014 4:06 PM, Alexander Motin wrote: >> Author: mav >> Date: Tue Jun 3 21:06:03 2014 >> New Revision: 267029 >> URL: http://svnweb.freebsd.org/changeset/base/267029 >> >> Log: >> Replace gethrtime() with cpu_ticks(), as source of random for the taskqueue >> selection. gethrtime() in our port updated with HZ rate, so unusable for >> this specific purpose, completely draining benefit of multiple taskqueues. >> >> MFC after: 2 weeks >> >> Modified: >> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c >> >> Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c >> ============================================================================== >> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun 3 21:02:19 2014 (r267028) >> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun 3 21:06:03 2014 (r267029) >> @@ -953,7 +953,7 @@ spa_taskq_dispatch_ent(spa_t *spa, zio_t >> if (tqs->stqs_count == 1) { >> tq = tqs->stqs_taskq[0]; >> } else { >> - tq = tqs->stqs_taskq[gethrtime() % tqs->stqs_count]; >> + tq = tqs->stqs_taskq[cpu_ticks() % tqs->stqs_count]; >> } >> >> taskq_dispatch_ent(tq, func, arg, flags, ent); >> > > FYI r267038. Thanks. I am sorry. -- Alexander Motin