From owner-freebsd-net@FreeBSD.ORG  Thu May 17 02:40:09 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5AC07106566C
	for <freebsd-net@hub.freebsd.org>; Thu, 17 May 2012 02:40:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EBB78FC1A
	for <freebsd-net@hub.freebsd.org>; Thu, 17 May 2012 02:40:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4H2e9hV002577
	for <freebsd-net@freefall.freebsd.org>; Thu, 17 May 2012 02:40:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4H2e9jl002576;
	Thu, 17 May 2012 02:40:09 GMT (envelope-from gnats)
Date: Thu, 17 May 2012 02:40:09 GMT
Message-Id: <201205170240.q4H2e9jl002576@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: "Devon H. O'Dell" <devon.odell@gmail.com>
Cc: 
Subject: Re: kern/110284: [if_ethersubr] Invalid Assumption in SIOCSIFADDR
	in ether_ioctl()
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "Devon H. O'Dell" <devon.odell@gmail.com>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 May 2012 02:40:09 -0000

The following reply was made to PR kern/110284; it has been noted by GNATS.

From: "Devon H. O'Dell" <devon.odell@gmail.com>
To: bug-followup@freebsd.org, freebsd-net@freebsd.org, gavin@freebsd.org
Cc:  
Subject: Re: kern/110284: [if_ethersubr] Invalid Assumption in SIOCSIFADDR in ether_ioctl()
Date: Wed, 16 May 2012 22:37:36 -0400

 2012/5/16 Devon H. O'Dell <devon.odell@gmail.com>:
 > Hi Gavin, freebsd-net,
 >
 > --- if_ethersubr.c =A0 =A0 =A02011-09-22 20:51:37.000000000 -0400
 > +++ /home/dho/if_ethersubr.c =A0 =A02012-05-16 22:27:17.000000000 -0400
 > @@ -1146,7 +1146,9 @@
 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0switch (ifa->ifa_addr->sa_family) {
 > =A0#ifdef INET
 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case AF_INET:
 > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ifp->if_init(ifp->if_softc)=
 ; =A0 =A0/* before arpwhohas */
 > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (ifp->if_flags & IFF_RUN=
 NING =3D=3D 0) {
 
 That's probably ((ifp->if_flags & IFF_RUNNING) =3D=3D 0). Also, I'm not on
 freebsd-net or cc'ed on the PR afaik, so please cc me explicitly on
 followups if more information is needed.
 
 --dho
 
 > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ifp->if_ini=
 t(ifp->if_softc); =A0 =A0/*
 > before arpwhohas */
 > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0arp_ifinit(ifp, ifa);
 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
 > =A0#endif