From owner-freebsd-ports@FreeBSD.ORG Sun Jun 10 20:38:52 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E0E9B1065674 for ; Sun, 10 Jun 2012 20:38:52 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6C9638FC0A for ; Sun, 10 Jun 2012 20:38:52 +0000 (UTC) Received: by bkvi18 with SMTP id i18so3749342bkv.13 for ; Sun, 10 Jun 2012 13:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=XQv22gmR+sjbV2TpkaVPCGhEHpQ8wD5swbTGzFQ17pk=; b=wUUUEXPQABd0aOo4TzhqunDH8UZw/dFnSsgoUROcoPpKWklm7DmmIBk5RSnLeCiHRi XBeaTz6KEU+ZoED2sUBF8V8TO2HM9imj4jTs6I/9bHaiFz/rDZgTVeqOpG4l5CgtCVGi sZnZlzZDuqDKpFK3+qUzycXF0na2zLTa/vfykpdgBkOxJjOd/7SOwvozAvIAgj8Hw2Zj 2wrf5gCSJEs7HzoA6hepCWctckCIg0ON3N9YXOjsbvye5vMcKM7NzhS3rUSYQm1RzDos qJ17ZkeTD5eE6ryqg3iRG9Y867f6HxaGdtG8875J6KbxdanUoBy1Ce/OrVhaTWTjKwpK Enrg== Received: by 10.204.153.15 with SMTP id i15mr9383615bkw.74.1339360731479; Sun, 10 Jun 2012 13:38:51 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.171.138 with HTTP; Sun, 10 Jun 2012 13:38:21 -0700 (PDT) In-Reply-To: <4FD50115.1070904@ateamsystems.com> References: <4FD50115.1070904@ateamsystems.com> From: Chris Rees Date: Sun, 10 Jun 2012 21:38:21 +0100 X-Google-Sender-Auth: g_9lMJFzzXPB0tkxBBi6wivLdaU Message-ID: To: Adam Strohl Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports@freebsd.org Subject: Re: Retro-actively adjust port's deinstall operations? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2012 20:38:53 -0000 On 10 June 2012 21:18, Adam Strohl wrote: > Hello, > > I've just submitted a PR to update the CouchDB port from 1.1.0 to 1.2.0: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D168923 > > Background: CouchDB's local.ini file stores all overridden options and > default.ini the defaults, similar to /etc/rc.conf & /etc/defaults/rc.conf= . > > While updating the port I discovered that the existing port lists local.i= ni > directly in pkg-plist instead of installing a local.ini.sample file and > doing proper comparisons/tests for changes. =A0So it blindly removes this= file > on deinstall. > > If my diff in the above PR is accepted when people uninstall the existing > 1.1.0 port it will remove their config file. =A0The new port will see tha= t > there is no local.ini and copy in the sample for them but this is really > awful for obvious reasons. > > Is there a way to reach people with a warning about this _before_ they > uninstall/reinstall so they can back up the file before upgrading? > > Or is /usr/ports/UPDATING it? (and do I need to do anything special to ha= ve > this listed there?) I'm sorry, you're rather stuffed there. The same happened with a port I took over a while ago. Actually if the older version doesn't install a .sample file (as it doesn't), you could put a big warning in for it: .include .if exists(${PREFIX}/whateverconfigfile) && !exists(${PREFIX}/whateverconfigfile.sample) IGNORE=3D Please see UPDATING note {date} .endif Stick a note in UPDATING (perhaps like 20110815), and send a HEADSUP to por= ts@: BEFORE you deinstall couchdb, make sure you take a backup of default.ini, because the port will clobber it. I've grabbed your PR and will investigate tomorrow. Chris