Date: Thu, 25 Aug 2016 10:11:41 +0100 From: Chris Rees <crees@physics.org> To: Mathieu Arnold <mat@FreeBSD.org>, Chris Rees <crees@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420830 - in head/databases: . neo4j neo4j/files Message-ID: <6C64CE8A-06BF-48F8-A7B0-B4F7D9552061@physics.org> In-Reply-To: <117832A4D3327FBB22E27C1A@atuin.in.mat.cc> References: <201608250219.u7P2JFVf030918@repo.freebsd.org> <117832A4D3327FBB22E27C1A@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 August 2016 09:47:07 BST, Mathieu Arnold <mat@FreeBSD.org> wrote:
>
>
>+--On 25 août 2016 02:19:15 +0000 Chris Rees <crees@FreeBSD.org> wrote:
>| +post-patch:
>| + ${REINPLACE_CMD} ${_SUB_LIST_TEMP} ${WRKSRC}/bin/neo4j-shared.sh \
>| + ${WRKSRC}/conf/neo4j.conf
>
>_SUB_LIST_TEMP is an undocumented *internal* framework variable. It
>should
>*never* be used in a port's Makefile.
>With the amount of things I'm rewriting, it may disapear any day, and I
>will not hunt down the ports that use it where they should not.
I must say I had a reservation about using it, although I think I've seen this done before. I think this should be exposed as ${SUB_SED_COMMAND} or something because it's useful.
Is there a mechanism for having patchfiles as SUB_FILES?
Chris
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6C64CE8A-06BF-48F8-A7B0-B4F7D9552061>