From owner-freebsd-hackers@freebsd.org  Fri Dec 29 18:19:43 2017
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F361EA9213
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Fri, 29 Dec 2017 18:19:43 +0000 (UTC) (envelope-from yuri@rawbw.com)
Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42])
 by mx1.freebsd.org (Postfix) with ESMTP id 06B597469A
 for <freebsd-hackers@FreeBSD.org>; Fri, 29 Dec 2017 18:19:42 +0000 (UTC)
 (envelope-from yuri@rawbw.com)
Received: from yv.noip.me (c-24-6-186-56.hsd1.ca.comcast.net [24.6.186.56])
 (authenticated bits=0)
 by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id vBTIJZAA083137
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO)
 for <freebsd-hackers@FreeBSD.org>; Fri, 29 Dec 2017 10:19:36 -0800 (PST)
 (envelope-from yuri@rawbw.com)
X-Authentication-Warning: shell1.rawbw.com: Host
 c-24-6-186-56.hsd1.ca.comcast.net [24.6.186.56] claimed to be yv.noip.me
To: Freebsd hackers list <freebsd-hackers@FreeBSD.org>
From: Yuri <yuri@rawbw.com>
Subject: Is it considered to be ok to not check the return code of close(2) in
 base?
Message-ID: <24acbd94-c52f-e71a-8a96-d608a10963c6@rawbw.com>
Date: Fri, 29 Dec 2017 10:19:34 -0800
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 18:19:43 -0000

Some base utilities sometimes close files that they open for their 
purposes without checking the error code of close(2).

Is this considered to be ok, because it's just a close call and we are 
done with that file descriptor, or is it considered to be more 
appropriate to check close's error code?

Maybe there is some policy that covers this?

IMO, every system call's return value should be checked, just in case.


Yuri