From owner-freebsd-current@FreeBSD.ORG  Mon Jun  9 03:55:13 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 966F237B401; Mon,  9 Jun 2003 03:55:13 -0700 (PDT)
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua
	[212.110.138.65])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BD93743FB1; Mon,  9 Jun 2003 03:55:07 -0700 (PDT)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1])
	h59AsLP6058259
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 9 Jun 2003 13:54:22 +0300 (EEST)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h59AsLjS058256;
	Mon, 9 Jun 2003 13:54:21 +0300 (EEST)
	(envelope-from ru)
Date: Mon, 9 Jun 2003 13:54:21 +0300
From: Ruslan Ermilov <ru@freebsd.org>
To: netchild@freebsd.org
Message-ID: <20030609105421.GB46569@sunbay.com>
References: <200306090828.h598SYqI008965@open.nlnetlabs.nl>
	<20030609112245.573a7e5f.Alexander@Leidinger.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="MfFXiAuoTsnnDAfZ"
Content-Disposition: inline
In-Reply-To: <20030609112245.573a7e5f.Alexander@Leidinger.net>
User-Agent: Mutt/1.5.4i
cc: ports@freebsd.org
cc: deischen@freebsd.org
cc: freebsd-current@freebsd.org
cc: rwatson@freebsd.org
cc: avleeuwen@piwebs.com
cc: Ted Lindgreen <ted@NLnetLabs.nl>
cc: lioux@freebsd.org
Subject: Re: Re Regression: Playing QT files from mplayer stopped working in
	5.1
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jun 2003 10:55:14 -0000


--MfFXiAuoTsnnDAfZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 09, 2003 at 11:22:45AM +0200, Alexander Leidinger wrote:
> On Mon, 9 Jun 2003 10:28:33 +0200
> ted@NLnetLabs.nl (Ted Lindgreen) wrote:
>=20
> > However, I guess that mplayer has had this error already, but that
> > a change in uthread_close.c as of May 31 has caused this problem
> > to show up now.
> > In particular: the unprotected usage of a very large value of "fd"
> > in "_thread_fd_table[fd]" leads to the segmentation violation.
> >=20
> > Previously the systemcall just returned an error without getting
> > into a segmentation violation.
>=20
> > Question:
> >   shouldn't _close in uthread_close.c do some sanity check on "fd"
> >   before using it as an array index?
>=20
> Try the attached patch.
>=20
Alexander,

This patch looks great.  Please commit it.


--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software Ltd,
ru@FreeBSD.org		FreeBSD committer

--MfFXiAuoTsnnDAfZ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+5GddUkv4P6juNwoRAgvKAJ4iy1NKV3vOnb8FEhr9FHkmNAqfSACfdpec
ZdZ64gtwy0Xxl6U43cWJoxM=
=rQ8J
-----END PGP SIGNATURE-----

--MfFXiAuoTsnnDAfZ--