From owner-freebsd-bugs@freebsd.org Mon Jun 17 11:32:27 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAFA115B5E9B for ; Mon, 17 Jun 2019 11:32:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 635888BE15 for ; Mon, 17 Jun 2019 11:32:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1D3EB15B5E93; Mon, 17 Jun 2019 11:32:27 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA0AB15B5E92 for ; Mon, 17 Jun 2019 11:32:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7BBFA8BE0E for ; Mon, 17 Jun 2019 11:32:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id B70AB4F94 for ; Mon, 17 Jun 2019 11:32:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5HBWPbu057143 for ; Mon, 17 Jun 2019 11:32:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5HBWN0N057091 for bugs@FreeBSD.org; Mon, 17 Jun 2019 11:32:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238662] mpt: replace mpt_prt with mpt_lprt in mpt_cam.c Date: Mon, 17 Jun 2019 11:32:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: huangfq.daxian@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2019 11:32:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238662 Bug ID: 238662 Summary: mpt: replace mpt_prt with mpt_lprt in mpt_cam.c Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: huangfq.daxian@gmail.com Created attachment 205180 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D205180&action= =3Dedit The patch file Replace mpt_prt with mpt_lprt with DEBUG level to print kernel pointers in a certain debug level. Signed-off-by: Fuqian Huang --- sys/dev/mpt/mpt_cam.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/sys/dev/mpt/mpt_cam.c b/sys/dev/mpt/mpt_cam.c index 4fbca1d9fe2..1083e083a82 100644 --- a/sys/dev/mpt/mpt_cam.c +++ b/sys/dev/mpt/mpt_cam.c @@ -1249,7 +1249,8 @@ mpt_timeout(void *arg) MPT_LOCK_ASSERT(mpt); req =3D ccb->ccb_h.ccb_req_ptr; - mpt_prt(mpt, "request %p:%u timed out for ccb %p (req->ccb %p)\n", = req, + mpt_lprt(mpt, MPT_PRT_DEBUG, + "request %p:%u timed out for ccb %p (req->ccb %p)\n", req, req->serno, ccb, req->ccb); /* XXX: WHAT ARE WE TRYING TO DO HERE? */ if ((req->state & REQ_STATE_QUEUED) =3D=3D REQ_STATE_QUEUED) { @@ -2598,7 +2599,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request= _t *req, scsi_req =3D (MSG_SCSI_IO_REQUEST *)req->req_vbuf; ccb =3D req->ccb; if (ccb =3D=3D NULL) { - mpt_prt(mpt, "mpt_scsi_reply_handler: req %p:%u with no ccb= \n", + mpt_lprt(mpt, MPT_PRT_DEBUG, + "mpt_scsi_reply_handler: req %p:%u with no ccb\n", req, req->serno); return (TRUE); } @@ -2655,7 +2657,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request= _t *req, if ((req->state & REQ_STATE_TIMEDOUT) =3D=3D 0) { TAILQ_REMOVE(&mpt->request_pending_list, req, links); } else { - mpt_prt(mpt, "completing timedout/aborted req %p:%u\n", + mpt_lprt(mpt, MPT_PRT_DEBUG, + "completing timedout/aborted req %p:%u\n", req, req->serno); TAILQ_REMOVE(&mpt->request_timeout_list, req, links); } @@ -4017,7 +4020,8 @@ mpt_recover_commands(struct mpt_softc *mpt) uint8_t response; MSG_REQUEST_HEADER *hdrp =3D req->req_vbuf; - mpt_prt(mpt, "attempting to abort req %p:%u function %x\n", + mpt_lprt(mpt, MPT_PRT_DEBUG, + "attempting to abort req %p:%u function %x\n", req, req->serno, hdrp->Function); ccb =3D req->ccb; if (ccb =3D=3D NULL) { @@ -4092,7 +4096,8 @@ mpt_recover_commands(struct mpt_softc *mpt) mpt_reset(mpt, TRUE); continue; } - mpt_prt(mpt, "abort of req %p:%u completed\n", req, req->serno); + mpt_lprt(mpt, MPT_PRT_DEBUG, + "abort of req %p:%u completed\n", req, req->serno); } } --=20 You are receiving this mail because: You are the assignee for the bug.=