Date: Mon, 06 Feb 2012 03:00:57 +0100 From: Dirk Engling <erdgeist@erdgeist.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: freebsd-rc@FreeBSD.org Subject: Re: Proposal ipv6_addrs_common Message-ID: <4F2F3459.3090401@erdgeist.org> In-Reply-To: <20120206.101800.1389796154758679137.hrs@allbsd.org> References: <4F28B9D7.4010602@erdgeist.org> <4F2F209F.90309@erdgeist.org> <20120206.101800.1389796154758679137.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06.02.12 02:18, Hiroki Sato wrote: > I also looked into an ipv6 counterpart of the ipv4_addrs_common, > and your patch looks good, but I am a bit concerned about adding > another independent knob to configure IPv6 addresses to rc.conf. I > feel this range specification can be integrated into > ifconfig_IF_aliasN and it will be simpler than adding another knob. > What do you think about it? Personally I do not like the fragile way of enumerating variables with the aliasN functions at all. It clutters the rc.conf with gazillion lines of config code, you always have to renumber the whole list when adding or removing one. It also broke and locked me out of my system in the past when I was just commenting out one IP address up in the address list, other users of systems with a lot of jails - and thus a lot of IP addresses - reported the same. The ipv4_addrs_common patch was a relief back then. But now v6 addresses start becoming common, so my configs fill up again. Since ipv6_addrs_common and ipv4_addrs_common share some code, especially handling v6 mapped v4 addresses, I could imagine just having one variable providing both v6 and v4 addresses and have an ip_addrs_common figure out which are which. There's other code in the rc system that uses the same enumeration scheme - the jail script and its _exec_afterstartN variables. My plans for the near future are proposing a new way of managing your jails, avoiding these error prone constructions. Regards and that you for your feedback, erdgeist -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk8vNFkACgkQuN1wFypsMNPrHQCeIDMIHeLVTbfR9MsSRpVjXOtc FnMAn3nB7053Rlt9G0GDbBiH6tO7fTQi =C0fE -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F2F3459.3090401>