From owner-svn-src-head@FreeBSD.ORG Thu Jan 22 16:49:18 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 40A83434; Thu, 22 Jan 2015 16:49:18 +0000 (UTC) Received: from smtp6.ore.mailhop.org (smtp6.ore.mailhop.org [54.149.35.133]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1EFAEEAC; Thu, 22 Jan 2015 16:49:17 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by smtp6.ore.mailhop.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1YEKwX-00054F-5b; Thu, 22 Jan 2015 16:49:17 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t0MGnDuI004093; Thu, 22 Jan 2015 09:49:14 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+Fuh8lLdULr5lfkMYFElGA Message-ID: <1421945353.14601.402.camel@freebsd.org> Subject: Re: svn commit: r277511 - head/sys/dev/firewire From: Ian Lepore To: "Bjoern A. Zeeb" Date: Thu, 22 Jan 2015 09:49:13 -0700 In-Reply-To: References: <201501212008.t0LK8PhR001309@svn.freebsd.org> Content-Type: text/plain; charset="iso-8859-7" X-Mailer: Evolution 3.12.8 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, gibbs@FreeBSD.org, src-committers , Will Andrews X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 16:49:18 -0000 On Thu, 2015-01-22 at 16:26 +0000, Bjoern A. Zeeb wrote: > > On 21 Jan 2015, at 20:08 , Will Andrews wrote: > > > > Author: will > > Date: Wed Jan 21 20:08:24 2015 > > New Revision: 277511 > > URL: https://svnweb.freebsd.org/changeset/base/277511 > > > > Log: > > Fix remote DMA based firewire debugging when targeting > > systems with more than 4GB of physical memory. > > > > To remotely debug the system 'stealthy' which has a kernel > > with this change installed and firewire properly configured: > > > > % fwcontrol -m stealthy (or stealthy's firewire EUI64) > > % kgdb kernel /dev/fwmem0.0 > > > > sys/dev/firewire/fwohci.c: > > Rather than hard code the upper limit for hw based > > automatic responses to remote DMA requests at 4GB, > > program the hardware using Maxmem, the page number > > one higher than the highest physical page detected > > in the system. > > > > While here, garbage collect more useless splfw() > > calls. > > > > Submitted by: gibbs > > MFC after: 1 week > > Sponsored by: Spectra Logic > > MFSpectraBSD: 1110994 on 2015/01/06 > > arm doesnąt define a Maxmem; the kernel builds are thus currently broken. > > converting beaglebone.dts -> /storage/head/obj/arm.armv6/scratch/tmp/bz/head.svn/sys/BEAGLEBONE/beaglebone.dtb > /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewire/fwohci.c:1856:28: error: use of undeclared identifier 'Maxmem' > prequpper = ((uintmax_t)Maxmem << PAGE_SHIFT) >> 16; > ^ > /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewire/fwohci.c:1862:20: error: use of undeclared identifier 'Maxmem' > (uintmax_t)Maxmem << PAGE_SHIFT, > ^ > 2 errors generated. This is the first I've heard of Maxmem. I think I can get it added to arm pretty quickly. -- Ian