Date: Thu, 11 Jul 2013 08:42:23 -0300 From: William Grzybowski <william88@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski <wg@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent Message-ID: <CAHtVNLPCmTBpC2uvaYdR2%2B1qQpCgr2UqUmgycF9Qdg4oBgNMVA@mail.gmail.com> In-Reply-To: <20130711054533.GA70334@FreeBSD.org> References: <201307101754.r6AHshZl027414@svn.freebsd.org> <20130711054533.GA70334@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 11, 2013 at 2:45 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Wed, Jul 10, 2013 at 05:54:43PM +0000, William Grzybowski wrote: >> New Revision: 322724 >> URL: http://svnweb.freebsd.org/changeset/ports/322724 >> >> @@ -43,7 +46,7 @@ CONFIGURE_ARGS+= --disable-qt-dbus >> .endif >> >> post-patch: >> - @${REINPLACE_CMD} -e 's,qputenv,!&,' ${WRKSRC}/src/main.cpp >> + @${REINPLACE_CMD} -e 's|qputenv|!&|' ${WRKSRC}/src/main.cpp > > There are two problems with this part: > > 1) It gratuitously changes perfectly fine commas to (also perfectly fine > as it might seem) bars. Gratuitous commits should generally be avoided, as > they decrease STN ratio, and most importantly, they break 'svn blame'; > > 2) Prior to this commit, 'svn blame' would have shown that this line was > added by me in r307714, to suppress bogus warning on startup of qBittorrent. > I've reported this bug to upstream [1] roughly 8 months ago, and it was > subsequently fixed. If you would have carefully checked this (like you've > should), you would have realized that this post-patch: gimmick should just > be removed now, instead of essentially putting the bug back: > > // Set environment variable > if (!!qputenv("QBITTORRENT", QByteArray(VERSION))) { > std::cerr << "Couldn't set environment variable...\n"; > } > > This is how the code now looks after "make patch". That said, when becoming > a maintainer, it is very much advised to study how a port was maintained in > the past, what had been done on it, and for what reasons. Confirming with > upstream goes without saying. Thank you. It would make everyones life easier if you had put a comment in the post-patch line about that fact. Thank you. -- William Grzybowski ------------------------------------------ Curitiba/PR - Brasil
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHtVNLPCmTBpC2uvaYdR2%2B1qQpCgr2UqUmgycF9Qdg4oBgNMVA>