From owner-freebsd-stable@freebsd.org Sat Feb 2 00:19:03 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5866614C65A1 for ; Sat, 2 Feb 2019 00:19:03 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from mail.vx.sk (unknown [IPv6:2a01:4f8:191:9029::4]) by mx1.freebsd.org (Postfix) with ESMTP id B15928B15C for ; Sat, 2 Feb 2019 00:19:02 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from mail.vx.sk (localhost [127.0.0.1]) by mail.vx.sk (Postfix) with ESMTP id 97BD537EF0; Sat, 2 Feb 2019 01:18:56 +0100 (CET) X-Virus-Scanned: amavisd-new at mail.vx.sk Received: from mail.vx.sk by mail.vx.sk (amavisd-new, unix socket) with LMTP id lBXK-JHL_GUO; Sat, 2 Feb 2019 01:18:56 +0100 (CET) Received: from [IPv6:2a02:2450:1020:806e:2894:d460:442e:23e7] (unknown [IPv6:2a02:2450:1020:806e:2894:d460:442e:23e7]) by mail.vx.sk (Postfix) with ESMTPSA id 20B9737EDE; Sat, 2 Feb 2019 01:18:56 +0100 (CET) Subject: Re: Status of libarchive/bsdtar maintainership To: Warner Losh , Eugene Grosbein Cc: FreeBSD-STABLE Mailing List References: <5C53E4FE.1010501@grosbein.net> From: Martin Matuska Openpgp: preference=signencrypt Autocrypt: addr=mm@FreeBSD.org; prefer-encrypt=mutual; keydata= mQINBFhUn/MBEACxbpg9G9KKuROKDLgugNKr6c4lrp3lTvx4XwuA+EGLCC/tBwOE8ak5f21g /QogUnYkhpuI3XLqKGsuWCDFQHB3Wk1dUYE/7wk4Um4DyHrMncyUmAHYfy9OZ+ZVYDBcodxl BDtVHKG0lzNhTs/HNO4Ep6Ja/37GsbEJRqz0XRgqM6l7GYwCiltTaU3nJuGDeWtRsaZO5Xqm 36NoXNTlR4MYy1m+ddAZZexgonNX33MNaATlkcJgo1HIr7fUt2JcLjrM0LVd5BAbLEcaXSlE 0Dl6MjnOYsJLL/zjMQ8esfRzVNYYZiZvqHCCDLii3rOzdCiuaJ0D2BfZKZNF4ETi+tvtL4Yk miDUb9+jc7p/CbYRpk0eV/9O4JERtwI7TVvObksY4N88Oc882dNvbw8y3R9WLuIoRx69lBwT miYYlDt6kCd/7Wgprqq2Spmvyp5KOVm7qFi0F2SsMqsNWngdKbiMTXD2Rg0rZqpcnLdWcYys rAnnyuQHvR6WUmDaeJdAnSf3VBsavdK2sjjjqcqW8+0NGWBg2UaHgUGc1gh01hfkp5tjAyR2 G3jNSfzP0PtJIuxvOOwDZsdja/BW5bnuzjZUNGOoZQ8OcYR6By8uugfcmd4H6GK9+Yj+xUDn ook3WKksy80ekDT8KdC/XTdmRYYZRbtb8gjBGxdlzciC5l262wARAQABtB9NYXJ0aW4gTWF0 dXNrYSA8bW1ARnJlZUJTRC5vcmc+iQI9BBMBCAAnAhsDBQsJCAcCBhUICQoLAgQWAgMBAh4B AheABQJYVKWNBQkFo6AaAAoJEPBA9xlrqZr05uoP/0JduegGf9eD69vXJvDORE+eGhqHhEP3 v6mbfJ6ErmyaypKfbyWfLw2rdEaY14Wt8IEPQi8ULpTaJPZOjlk77BAZ/efPIBAvGNs0D1z4 24bn3uZM+pZhh6jY7nPkyajh8tDeMtixLiaK6re2/TRuIUPy7Y91P94uPgLVxx88qtI62gh5 Sc8oGY+OMQybtZ8S6kEuio3ZhQF4fXM92NUf1XY9BYZ330yiv/CQTz+Bz/nOHU7QqDG8OKVr UA0lNKfEcrF7dsrrBeLoC73FB+gqcHcTZ/A+ZlO+IWunWfs6plB7F92v4d3dzsHIuPt6Ldf2 tP+hmsMa0mGmL6zriG1vo3hxpRmRqlr5KTpa1yrjs/8PULfuae8qcGuUcytaZVhYzu2hIijw WJ0OxIF6EhV4maG/9bEINqNUaHzthrHbSVeYTR7i4EIGOXgK3jMZ9zhjUz70IzAcshNdypVO 6QeMB9Cv5ei975MKG0khRukdmg43Q4OijSmh6F4+Ikp5yTT3BfVUiK0Jy+ceGE+hU/fRFhPW p3+oyVXO9Xhng7LNvp+gT32UN9FLOVmAhPj0mYVSaHKs1MwCV2xZv1nJjVE9TbmwR1G27fyQ fXZ/m3+Gzl+mT+oD9FnsiFAO67FEm/O1GPPl4LSHWD5QP3L+RXXJ0sxTmDUew6XgbnVFNnua ypFauQINBFhUn/MBEADXMgH7m6goQbA8KVv4g1v/ok1qPrAFD9FVgNH52k3VJ2nX1aegASvP mEpf6p+JzLZqra0j/HMDsTiHBL6pYD2+d7UAvMFpYh+Tr32U4GcPAUJzCAl7pR5gERC24ULi nIm8uVP9Ovq4a4iYQyXkFmcE2clkcW+RBgQaRfYxfznF32imC6A2gohlU5QnmeHzpawuWxMe JWaU5GADhN8S4WRvhIN0mx+FXXUO3jhXK/Pm0DqFri45Dn/oJCXhfmLfjnABjJ5Rgr1qxdd+ xVdHrtv+sHu/yG1Jf/d9DTi/MPn5QZ5F1z/sWJzNHn49eDn+FUFqCdSDWRVJyikHa/fhRdpn pah3+Ec+AhCxMR2G0Ip/qpxKYepgvi+tKXX0ljfdT4Qjrty+bYfYzOCdV2NrSXs7c3spQ2Ni FZvx3qW+SdozlZf+ycGUMmEnKITZ4r2F9kJ8UH2z9b6TkdVe8G2bpKlUYDqEKWMs3haFeg21 fFc3JK8lf1eU0/b5V42wYYY2CpyY308Z7L73emKhr+3I4SaEomHP6u3KlF2Rx++jlrHMVV1i vsQgdCBZ6nusDGP9O067w2CFYLyGXeHnYcBVP7B1U64/cKATy02dJQthwIhbsAkYb4r3QTko V6eu8z+d2FABy3yjQn7JKmx3utem+Jmmd/Lj3TdkVw0m771wz4iA9wARAQABiQIfBBgBCAAJ BQJYVJ/zAhsMAAoJEPBA9xlrqZr0QYMQAJt7mnN+G9HQNrujBQkJ0YStWD41al2sYg0xeTRD XxDtGQx6B86kIjf5FQeatTQ6ZTdptQSJJWe/KvHkaG2RM8j55W8JzSnClQWEfmc5G1Frqm1b 0L3T8QXE/lPXS8ishBIqB6Ikw7FQulrd/Z4Xra3jxEjj3nRb6V74l3ZDILpBq9pte2PGTx5h KONPhWfu6oq4B9VK4WuFMeoD7+jlVPNtiauQnTXZJfHAT5RGNz6Mwc24oKsmYxLfwkJVdrTr QjQKLcSKxG0EiP07UbLRq3y3EQVPCS3zqdB3QKOCH9hc306e2KXcmMjYMGX+k56L3p1DboIL gvFs8RzmyP0PbAN4zDsqtdtdE+ySQnp5JSlG1zQKrt/zq5VstBnCRhTZZdxqpAbeqXVG+hFX ub45yFkn/bt/mAUtFHd5O7L31J7+bGSfC+nENN1dX0yqFdSReSRZ+GmKPxuwanQ70VFJeHTS Ikbmf34TKAP6Ml7omu36LgMINy0gsZDbaucoQnSw59w+05vEH7KpuxFpvrCzp2kYKct9vLLG RWnRRprHT4lTJBmTB9nTT9+4svon1DcE01Cep4U28D4PlOMzu4UvtKD0HACy47BOh2F3ZYml 5iSedZln4uon0GUd6j1eB+ZUj6eFXuReqKXSkpzUPZKC45Oq1GIFEnOcS4CxpoKZByWQ Message-ID: <1f91bbad-492b-7427-6869-62145e107c67@FreeBSD.org> Date: Sat, 2 Feb 2019 01:18:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Rspamd-Queue-Id: B15928B15C X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2019 00:19:03 -0000 I have created a pull request for the proposed patch. It breaks bsdtar's test "test_missing_file" so I need to investigate. https://github.com/libarchive/libarchive/pull/1131 On 02.02.19 00:35, Warner Losh wrote: > > > On Thu, Jan 31, 2019 at 11:19 PM Eugene Grosbein > wrote: > > On 01.02.2019 11:10, Warner Losh wrote: > > > On Thu, Jan 31, 2019, 8:22 PM Eugene Grosbein > > > wrote: > > > >=C2=A0 =C2=A0 =C2=A0Hi! > > > >=C2=A0 =C2=A0 =C2=A0I wonder what is status of our contrib/libarch= ive and > bsdtar/bsdcpio etc. in modern versions of FreeBSD > >=C2=A0 =C2=A0 =C2=A0in a sense of serious bug fixing. Long story s= hort: I faced > a bug in the libarchive bundled with 11.2 > >=C2=A0 =C2=A0 =C2=A0that makes it impossible to create reliable ba= ckups of live > file system or its subtree > >=C2=A0 =C2=A0 =C2=A0using cron+bsdtar utility that delegate actial= work to the > libarchive that just aborts > >=C2=A0 =C2=A0 =C2=A0if a file disappears (is removed) in process (= GNU tar > continues with just warning). > > > >=C2=A0 =C2=A0 =C2=A0This is serious issue for me as I used 'tar' c= ommand to make > backups for distinct subtrees > >=C2=A0 =C2=A0 =C2=A0since FreeBSD 6.x and when my GPS+ntpd subsyst= em went insane > and shifted system clock to 3 years > >=C2=A0 =C2=A0 =C2=A0in the future, I lost data in several thousand= s of RRD > databases and looked for backups to restore them > >=C2=A0 =C2=A0 =C2=A0and found only small portion of databases in t= he tar instead > of full backup. > > > >=C2=A0 =C2=A0 =C2=A0I've create the PR > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233006 and late= r > attached a patch > >=C2=A0 =C2=A0 =C2=A0solving the problem in same way as GNU tar dea= ls with it. > > > >=C2=A0 =C2=A0 =C2=A0Martin Matuska (mm) asked me to create an issu= e at GitHub > for libarchive. > >=C2=A0 =C2=A0 =C2=A0I have no GitHub account nor I need one, and h= e was so kind > and created it himself: > >=C2=A0 =C2=A0 =C2=A0https://github.com/libarchive/libarchive/issue= s/1082 > > > >=C2=A0 =C2=A0 =C2=A0Almost 3 months have passed and no response fr= om upstream. > >=C2=A0 =C2=A0 =C2=A0Should we go ahead and fix it despite of it is= part of contrib? > > > > > > If you fix it, protocol is to submit it upstream first. > > That was done 3 months ago. > > > I see the problem report in the github, but no pull request. Did I > miss it? > =C2=A0 > > > It causes fewer problems in the long run. While it is tempting > to just fix it in FreeBSD and move on, > > almost every time we've done that in the past someone else has > had to come in and fix the mess. > > > > Do you have a fix? Can you put it up for review somewhere? > > It is attached to mentioned PR: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233006#c6 > > > Did you submit it as a pull request? That seems to be how this > upstream takes in code. > > > We are no where near a release, so there is no reason to rush > this in. > > I waited for almost 3 months already. It seems, there would be no > response at all. > > > They didn't fix it in 3 months, sure. But it wasn't clear from the > issue that you had an actual fix (I certainly missed that the first > time through when I only looked at the github and not at our bug > database). I'd try submitting a pull request and see what happens. I'd > also send an email to mm@ telling him about the pull request and > asking when he'll have time to look into=C2=A0 integrating it or commen= ting > on it. If he won't have time to get to it soon, I'd make the commit > referencing the upstream pull request so the next person who imports > things will notice if they tweak it before accepting the request. > > Warner=C2=A0