From owner-freebsd-firewire@FreeBSD.ORG Wed Dec 19 18:21:42 2007 Return-Path: Delivered-To: freebsd-firewire@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCAF616A419; Wed, 19 Dec 2007 18:21:42 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from plato.miralink.com (mail.miralink.com [70.103.185.20]) by mx1.freebsd.org (Postfix) with ESMTP id B035713C45B; Wed, 19 Dec 2007 18:21:42 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from localhost (localhost.localdomain [127.0.0.1]) by plato.miralink.com (Postfix) with ESMTP id 60D571C81BD; Wed, 19 Dec 2007 10:21:42 -0800 (PST) Received: from plato.miralink.com ([127.0.0.1]) by localhost (plato.miralink.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 10696-09; Wed, 19 Dec 2007 10:21:41 -0800 (PST) Received: from iago.office.miralink.com (iago.office.miralink.com [10.0.0.40]) by plato.miralink.com (Postfix) with ESMTP id A37611C81BB; Wed, 19 Dec 2007 10:21:41 -0800 (PST) Message-ID: <47696135.8060508@miralink.com> Date: Wed, 19 Dec 2007 10:21:41 -0800 From: Sean Bruno User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Hidetoshi Shimokawa References: <476610E5.2060108@miralink.com> <626eb4530712162258s4dfe1448o1102f20a623d3f95@mail.gmail.com> <476696C4.60408@miralink.com> <626eb4530712182320q237c344crd309893a82fe8ef8@mail.gmail.com> <4768D2DD.2010500@miralink.com> In-Reply-To: <4768D2DD.2010500@miralink.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DSPAM-Result: Innocent X-DSPAM-Processed: Wed Dec 19 10:21:42 2007 X-DSPAM-Confidence: 0.7829 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 47696136144251527717022 X-DSPAM-Factors: 27, X-Virus-Scanned: amavisd-new at X-Spam-Status: No, score=-4.499 tagged_above=-10 required=6.6 autolearn=ham tests=[ALL_TRUSTED=-1.8, BAYES_00=-2.599, DSPAM_HAM=-0.1] X-Spam-Score: -4.499 X-Spam-Level: Cc: freebsd-firewire@freebsd.org Subject: Re: sbp_targ memory leak X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2007 18:21:42 -0000 Sean Bruno wrote: > Hidetoshi Shimokawa wrote: >> I think you are right and page table is not freed when CAM_SEND_STATUS >> is not set. >> Maybe we should always free page tables if refcont == 0 rather than >> free in sbp_targ_send_status(). >> I thought about this some more this morning. What is causing us to allocate two page tables per XPT_CONT_TARGET_IO? The address printed out for the XPT_CONT_TARGET_IO call is identical, so I assume that these operations were for the same SCSI command. >> You patch is not just adding debug printfs, right? Yes, there is additions for XPT_SET_TRAN_SETTINGS /XPT_GET_TRAN_SETTINGS, additional CAM_SEND_SENSE flags and remove the requirement for target 0. Sean