From owner-svn-src-head@freebsd.org Sun Oct 21 09:55:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8EDEEFE846E; Sun, 21 Oct 2018 09:55:38 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2E86784AB7; Sun, 21 Oct 2018 09:55:38 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 052E7472AF; Sun, 21 Oct 2018 11:55:31 +0200 (CEST) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_327A302A-8CB5-457E-94EE-80BE203B84AB"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r339436 - in head: . contrib/gcc gnu/usr.bin/cc/cc_tools lib/clang release sys/conf sys/sys Date: Sun, 21 Oct 2018 11:55:20 +0200 In-Reply-To: Cc: Glen Barber , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Jan Beich References: <201810190037.w9J0blks031617@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2018 09:55:38 -0000 --Apple-Mail=_327A302A-8CB5-457E-94EE-80BE203B84AB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 21 Oct 2018, at 04:08, Jan Beich wrote: >=20 > Glen Barber writes: >=20 >> Modified: head/lib/clang/llvm.build.mk >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/lib/clang/llvm.build.mk Fri Oct 19 00:24:23 2018 = (r339435) >> +++ head/lib/clang/llvm.build.mk Fri Oct 19 00:37:47 2018 = (r339436) >> @@ -17,7 +17,7 @@ CFLAGS+=3D -I${LLVM_SRCS}/include >> CFLAGS+=3D -DLLVM_BUILD_GLOBAL_ISEL >> CFLAGS+=3D -D__STDC_LIMIT_MACROS >> CFLAGS+=3D -D__STDC_CONSTANT_MACROS >> -#CFLAGS+=3D -DNDEBUG >> +CFLAGS+=3D -DNDEBUG >=20 > Would Clang still hit asserts instead of crashing with cryptic = messages? In llvm, assertions (and various other internal consistency checks) are turned off by defining NDEBUG. So indeed, if something in the internal state goes in an unexpected direction, you could get crashes or other "interesting" effects. That said, the resulting executable(s) should run somewhat faster, and be somewhat smaller. I think we have always done this for stable branches and releases. If users encounter such crashes, it will still write reproduction files (self-contained .c or .cpp file and a shell script), so those can be included in bug reports, and run on a copy of clang with assertions. -Dimitry --Apple-Mail=_327A302A-8CB5-457E-94EE-80BE203B84AB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW8xNCAAKCRCwXqMKLiCW oyaXAKDXEZI/4cWTB0qr543kJc1XjK6q6wCg7D8vIQthMTJMRptfRii+bIs5uDE= =NuZA -----END PGP SIGNATURE----- --Apple-Mail=_327A302A-8CB5-457E-94EE-80BE203B84AB--