From owner-svn-src-all@FreeBSD.ORG Thu Feb 28 20:02:33 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7594EEE4; Thu, 28 Feb 2013 20:02:33 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-02-ewr.mailhop.org (mho-04-ewr.mailhop.org [204.13.248.74]) by mx1.freebsd.org (Postfix) with ESMTP id 4D5FFF4F; Thu, 28 Feb 2013 20:02:33 +0000 (UTC) Received: from c-24-8-232-202.hsd1.co.comcast.net ([24.8.232.202] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1UB9gW-0009iV-C9; Thu, 28 Feb 2013 20:02:32 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r1SK2Ufr085696; Thu, 28 Feb 2013 13:02:30 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.232.202 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX193HzQ61HZO7nWQBJG4J876 Subject: Re: svn commit: r247495 - head/sys/dev/sdhci From: Ian Lepore To: Oleksandr Tymoshenko In-Reply-To: <201302281943.r1SJhEmC023261@svn.freebsd.org> References: <201302281943.r1SJhEmC023261@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Thu, 28 Feb 2013 13:02:30 -0700 Message-ID: <1362081750.1195.65.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2013 20:02:33 -0000 On Thu, 2013-02-28 at 19:43 +0000, Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Thu Feb 28 19:43:14 2013 > New Revision: 247495 > URL: http://svnweb.freebsd.org/changeset/base/247495 > > Log: > Add hooks for plugging platform-provided transfer backend. > > In order to use platorm backend hardware driver should > impement three methods: > - platform_start_transfer and platform_finish_transfer > to start and finish transfer > - platform_will_handle - check whether transaction is > suitable for backend. If not - driver will fall back > to PIO mode. > > Submitted by: Daisuke Aoyama > Approved by: ian@ > > Modified: > head/sys/dev/sdhci/sdhci.c > head/sys/dev/sdhci/sdhci.h > head/sys/dev/sdhci/sdhci_if.m > I think that was meant to be "Reviewed by" rather than "Approved by". I do very much approve of the changes, but not in any formal administrative sense, I'm just happy the sdcard IO is faster. :) -- Ian