From owner-cvs-src@FreeBSD.ORG Mon Mar 6 23:51:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CE6216A420; Mon, 6 Mar 2006 23:51:55 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9958C43D69; Mon, 6 Mar 2006 23:51:50 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k26NpcWG007344; Mon, 6 Mar 2006 16:51:39 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <440CCB02.4080905@samsco.org> Date: Mon, 06 Mar 2006 16:51:30 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <20060305175247.149A616A44F@hub.freebsd.org> <440B41DF.1010305@root.org> <20060306.162218.20524465.imp@bsdimp.com> In-Reply-To: <20060306.162218.20524465.imp@bsdimp.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org, cvs-all@FreeBSD.org, nate@root.org Subject: Re: cvs commit: src/sys/dev/usb umass.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2006 23:51:55 -0000 M. Warner Losh wrote: > In message: <440B41DF.1010305@root.org> > Nate Lawson writes: > : Poul-Henning Kamp wrote: > : > phk 2006-03-05 17:52:32 UTC > : > > : > FreeBSD src repository > : > > : > Modified files: > : > sys/dev/usb umass.c > : > Log: > : > When we get an unknown ATAPI comand, try it even if it is not listed, > : > in all likelyhood just passing it through will work. > : > > : > Revision Changes Path > : > 1.134 +4 -2 src/sys/dev/usb/umass.c > : > : Given that most umass devices can't even handle the commands required by > : the spec (RBC), this seems dangerous. Still, might be worth trying in > : HEAD just to see what commands it needs to support. > > It depends on the umass device. The thumb drives are universally > stupid and fragile. This change is dangerous for them (although why > one would send arbitrary commands to them I know not). There are a > number of usb2 to PATA or SATA that this fix is the right thing to do, > since for those it is required to get things like cdrecord to run w/o > complaint. > > Warner What would likely have been safer, and I meant to discuss this with PHJK but forgot, is to only pass commands that are 10 bytes long, and summarily reject all others. Scott