From owner-freebsd-bugs  Wed Sep 23 12:30:16 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id MAA27633
          for freebsd-bugs-outgoing; Wed, 23 Sep 1998 12:30:16 -0700 (PDT)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA27568
          for <freebsd-bugs@FreeBSD.org>; Wed, 23 Sep 1998 12:30:01 -0700 (PDT)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id MAA12485;
	Wed, 23 Sep 1998 12:30:00 -0700 (PDT)
Date: Wed, 23 Sep 1998 12:30:00 -0700 (PDT)
Message-Id: <199809231930.MAA12485@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: dag-erli@ifi.uio.no (Dag-Erling C. =?iso-8859-1?Q?Sm=F8rgrav?= )
Subject: Re: conf/8031: /etc/rc looks for /etc/sendmail.cf at startup
Reply-To: dag-erli@ifi.uio.no (Dag-Erling C. =?iso-8859-1?Q?Sm=F8rgrav?= )
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

The following reply was made to PR conf/8031; it has been noted by GNATS.

From: dag-erli@ifi.uio.no (Dag-Erling C. =?iso-8859-1?Q?Sm=F8rgrav?= )
To: Studded <Studded@dal.net>
Cc: Drew Derbyshire <ahd@kew.com>, freebsd-bugs@FreeBSD.ORG,
        freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: conf/8031: /etc/rc looks for /etc/sendmail.cf at startup
Date: 23 Sep 1998 21:20:15 +0200

 Studded <Studded@dal.net> writes:
 > 	This isn't directed towards Drew, but technically the RHS of the test
 > should be "XYES" instead of how it is now. The '=' conditional compares
 > strings, so the LHS is correct, and it should be the same on both sides.
 > [...]
 > >  ! if [ "X${sendmail_enable}" = X"YES" ]; then
 > >         echo -n ' sendmail';    /usr/sbin/sendmail ${sendmail_flags}
 > >    fi
 
 The X is totally unnecessary as long as you have quotes around the
 variable to make sure you get an empty string (rather than a missing
 argument) if it's undefined or empty.
 
 [ "${sendmail_enable}" = YES ] &&
   echo -n ' sendmail' && /usr/sbin/sendmail ${sendmail_flags}
 
 Might as well throw in a ${sendmail_program} for good measure:
 
 [ "${sendmail_enable}" = YES ] &&
   echo -n ' sendmail' && ${sendmail_program} ${sendmail_flags}
 
 I prefer to place the echo command last so that ' sendmail' is not
 printed unless sendmail started successfully.
 
 DES
 -- 
 Dag-Erling Smørgrav - dag-erli@ifi.uio.no

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message