From owner-cvs-src@FreeBSD.ORG Sun Sep 5 23:07:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6515816A4CE; Sun, 5 Sep 2004 23:07:46 +0000 (GMT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FE8F43D1F; Sun, 5 Sep 2004 23:07:45 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id i85N7h9J082989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 6 Sep 2004 03:07:44 +0400 (MSD) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id i85N7heo082988; Mon, 6 Sep 2004 03:07:43 +0400 (MSD) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Mon, 6 Sep 2004 03:07:43 +0400 From: Gleb Smirnoff To: Andre Oppermann Message-ID: <20040905230743.GA82892@cell.sick.ru> References: <200409052006.i85K6ovn042219@repoman.freebsd.org> <413B8C06.CBC43282@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <413B8C06.CBC43282@freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2004 23:07:46 -0000 On Sun, Sep 05, 2004 at 11:58:30PM +0200, Andre Oppermann wrote: A> Thanks. I was at the SUCON'04 the last days and only infrequently checking A> my inbox. The ipfw2 code never returned EINVAL for divert actions when the A> IPDIVERT was not compiled in. I didn't change that with the conversion to A> pfil_hooks. May be this check was in other place. I clearly remeber that rc.firewall on my 4.x boxes produced errors on divert with GENERIC loaded. I haven't looked at code but I have just checked: root@fade:~:|>ipfw add 65000 divert natd all from any to any ipfw: getsockopt(IP_FW_ADD): Invalid argument root@fade:~:|>uname -a FreeBSD fade.bestcom.ru 4.9-STABLE FreeBSD 4.9-STABLE #3: Mon Jan 12 12:30:42 MSK 2004 root@fade.bestcom.ru:/usr/obj/usr/src/sys/FADE i386 (no DIVERT in kernel). -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE