From owner-freebsd-net@FreeBSD.ORG Wed Jan 30 11:45:36 2013 Return-Path: Delivered-To: net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2FC9D459 for ; Wed, 30 Jan 2013 11:45:36 +0000 (UTC) (envelope-from oppermann@networx.ch) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 98AAA1EE for ; Wed, 30 Jan 2013 11:45:35 +0000 (UTC) Received: (qmail 87987 invoked from network); 30 Jan 2013 13:05:36 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 30 Jan 2013 13:05:36 -0000 Message-ID: <510907DC.3040900@networx.ch> Date: Wed, 30 Jan 2013 12:45:32 +0100 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: [patch] good bye sockaddr_inarp References: <20130130092544.GA84981@FreeBSD.org> In-Reply-To: <20130130092544.GA84981@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: net@FreeBSD.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2013 11:45:36 -0000 On 30.01.2013 10:25, Gleb Smirnoff wrote: > Hello! > > It looks to me that the only thing the sockaddr_inarp was > ever used for is to carry the SIN_PROXY flag. > > The SIN_PROXY flag in its turn, meant install a "proxy only" > ARP entry. Such entry behaves as any "published" entry, but > doesn't modify the routing table of the host. > > Please correct me, if I am wrong in the above ^^. Proxy arp is used for ppp for example when the remote end is given an IP address from a locally connected network. Usually the IP address was obtained via DHCP. The ppp server then installs a proxy ARP entry for this IP address to receive all packets for it and forward them over the PPP link. > Now, once ARP and routing are somewhat divorced, the meaning > of "proxy only" is lost, because any entry doesn't affect routing > table. We still need the proxy ARP functionality and semantics. The routing table however isn't involved anymore as you've observed. > This allows us to cleanup usage of SIN_PROXY and after that > it appears that we don't need sockaddr_inarp at all. Attached patch > does that. I didn't notice any functionality regressions, and I'd be > grateful if anyone points me at a test case, that would. > > P.S. More reading on the history can be found here: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=12357 Excellent. More cruft going away. -- Andre