From owner-svn-src-head@freebsd.org Mon Mar 11 15:45:53 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E060D1517FEA; Mon, 11 Mar 2019 15:45:52 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0CB536CB8E; Mon, 11 Mar 2019 15:45:51 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x2BFjkNf010152; Mon, 11 Mar 2019 08:45:46 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x2BFjk5s010151; Mon, 11 Mar 2019 08:45:46 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903111545.x2BFjk5s010151@ gndrsh.dnsmgr.net> Subject: Re: svn commit: r344990 - in head: share/man/man9 sys/dev/ath sys/dev/bwi sys/dev/bwn sys/dev/ipw sys/dev/iwi sys/dev/iwm sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/otus sys/dev/ral sys/dev/rtwn sys/... In-Reply-To: To: Warner Losh Date: Mon, 11 Mar 2019 08:45:46 -0700 (PDT) CC: "Rodney W. Grimes" , Andriy Voskoboinyk , src-committers , svn-src-all , svn-src-head Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 0CB536CB8E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 15:45:53 -0000 > On Sun, Mar 10, 2019 at 8:12 PM Rodney W. Grimes > wrote: > > > > Author: avos > > > Date: Mon Mar 11 01:27:01 2019 > > > New Revision: 344990 > > > URL: https://svnweb.freebsd.org/changeset/base/344990 > > > > > > Log: > > > Fix ieee80211_radiotap(9) usage in wireless drivers: > > > > > > - Alignment issues: > > > * Add missing __packed attributes + padding across all drivers; in > > > most places there was an assumption that padding will be always > > > minimally suitable; in few places - e.g., in urtw(4) / rtwn(4) - > > > padding was just missing. > > > * Add __aligned(8) attribute for all Rx radiotap headers since they > > can > > > contain 64-bit TSF timestamp; it cannot appear in Tx radiotap headers, > > so > > > just drop the attribute here. Refresh ieee80211_radiotap(9) man page > > > accordingly. > > > > > > - Since net80211 automatically updates channel frequency / flags in > > > ieee80211_radiotap_chan_change() drop duplicate setup for these fields > > > in drivers. > > > > > > Tested with Netgear WG111 v3 (urtw(4)), STA mode. > > > > > > MFC after: 2 weeks > > > > Isnt this going to seriously break module load compatibility > > due to struct size and alignment changes if you merge this to stable/12? > > > > It looks like all these changes are within the modules, not in the KBI... > It looks like this will make things work better on architectures that don't > like unaligned accesses. It seems like modules that aren't updated don't > work today on those architectures... Thank you for clarifying that; > Warner > > > Modified: > > > head/share/man/man9/ieee80211_radiotap.9 > > > head/sys/dev/ath/if_athioctl.h > > > head/sys/dev/bwi/if_bwi.c > > > head/sys/dev/bwi/if_bwivar.h > > > head/sys/dev/bwn/if_bwn.c > > > head/sys/dev/bwn/if_bwnvar.h > > ... > > -- > > Rod Grimes > > rgrimes@freebsd.org -- Rod Grimes rgrimes@freebsd.org