From nobody Sun May 31 10:01:04 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gSt121lGHz6gQHr; Sun, 31 May 2026 10:01:58 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp052.goneo.de (smtp052.goneo.de [85.220.129.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4gSt114tSRz3ksQ; Sun, 31 May 2026 10:01:57 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; none Received: from hub2.goneo.de (hub2.goneo.de [IPv6:2001:1640:5::8:53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id 2792A24070B; Sun, 31 May 2026 12:01:55 +0200 (CEST) Received: from hub2.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPS id 508DB2402FE; Sun, 31 May 2026 12:01:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1780221713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O1sWVLvjiocMmHT6ZhI/Lm0gakC69dUV53GADEB53Wo=; b=nbtP9S4kCQDHUsah8bjZWSARyhgnrHK6OBU8DdIA6Uj6q8wb8ryr7ivt0/pFuHGNlN0NdP yy8zteYPhQ2eWZ46rQDOPkB0E4WPPlsTNleQGF1Q+k3Eu3/+C4x0n+yRVeZynsX/Ldx7mQ kM9ucWuuu1ZiNg+0Xw5FX3GpaD+ffJivMQk9gLNPM/FWwz42D2bjJUCj/7shBFzMrZeJGH SkowEh/mVTTtc48CMmlDbfiQTXELz9xEdVckz77AmFwWBWWvIjeUJ7f0VCi9hvEoNLb5in BsfdmeMpM7mgq7+E6xOg5wajBmBCXeK/wRltWclwk9DMD//aZTYpJOUL/efpbg== Received: from thor.sb211.local (dynamic-2a02-3100-2853-b702-262e-ef0e-9cec-3228.310.pool.telefonica.de [IPv6:2a02:3100:2853:b702:262e:ef0e:9cec:3228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPSA id C0858240270; Sun, 31 May 2026 12:01:52 +0200 (CEST) Date: Sun, 31 May 2026 12:01:04 +0200 From: A FreeBSD User To: Ahmad Khalifa Cc: Kevin Bowling , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2fa4bdd7f9e9 - main - edk2: enable static asserts for *INT64 alignment Message-ID: <20260531120131.387a9bb8@thor.sb211.local> In-Reply-To: References: <6a1a4f38.32b9d.5eb5f95e@gitrepo.freebsd.org> <20260530190827.15ba6ffa@thor.sb211.local> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; amd64-portbld-freebsd16.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/.qitOwY9QtA6_x.HT94VhD5"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Rspamd-UID: 9c41ab X-Rspamd-UID: b9f2a2 X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:25394, ipnet:85.220.128.0/17, country:DE] X-Rspamd-Queue-Id: 4gSt114tSRz3ksQ X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --Sig_/.qitOwY9QtA6_x.HT94VhD5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Tage des Herren Sat, 30 May 2026 17:11:38 -0700 Ahmad Khalifa schrieb: > On Sun May 31, 2026 at 1:54 AM +0300, Kevin Bowling wrote: > > On Sat, May 30, 2026 at 2:50=E2=80=AFPM Ahmad Khalifa wrote: =20 > >> > >> On Sat May 30, 2026 at 8:09 PM +0300, A FreeBSD User wrote: =20 > >> > Am Tage des Herren Sat, 30 May 2026 02:45:12 +0000 > >> > Ahmad Khalifa schrieb: > >> > =20 > >> >> The branch main has been updated by vexeduxr: > >> >> > >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D2fa4bdd7f9e99698a665= 2db405c3165fdcd41c1d > >> >> > >> >> commit 2fa4bdd7f9e99698a6652db405c3165fdcd41c1d > >> >> Author: Ahmad Khalifa > >> >> AuthorDate: 2026-05-30 02:40:58 +0000 > >> >> Commit: Ahmad Khalifa > >> >> CommitDate: 2026-05-30 02:40:58 +0000 > >> >> > >> >> edk2: enable static asserts for *INT64 alignment > >> >> > >> >> The ia32 loader is now built with -malign-double, so these shou= ld pass. > >> >> > >> >> Differential Revision: https://reviews.freebsd.org/D55386 > >> >> --- > >> >> sys/contrib/edk2/Include/Base.h | 2 -- > >> >> 1 file changed, 2 deletions(-) > >> >> > >> >> diff --git a/sys/contrib/edk2/Include/Base.h b/sys/contrib/edk2/Inc= lude/Base.h > >> >> index 3ae798db8429..d3342c9a6ca2 100644 > >> >> --- a/sys/contrib/edk2/Include/Base.h > >> >> +++ b/sys/contrib/edk2/Include/Base.h > >> >> @@ -841,10 +841,8 @@ STATIC_ASSERT (ALIGNOF (INT16) =3D=3D sizeof= (INT16), "Alignment of > >> >> INT16 does not STATIC_ASSERT (ALIGNOF (UINT16) =3D=3D sizeof (UINT= 16), "Alignment of > >> >> UINT16 does not meet UEFI Specification Data Type requirements"); S= TATIC_ASSERT > >> >> (ALIGNOF (INT32) =3D=3D sizeof (INT32), "Alignment of INT32 does = not meet UEFI > >> >> Specification Data Type requirements"); STATIC_ASSERT (ALIGNOF (UIN= T32) =3D=3D sizeof > >> >> (UINT32), "Alignment of UINT32 does not meet UEFI Specification Dat= a Type > >> >> requirements"); -#ifndef _STANDALONE STATIC_ASSERT (ALIGNOF (INT64)= =3D=3D sizeof (INT64), > >> >> "Alignment of INT64 does not meet UEFI Specification Data Type requ= irements"); > >> >> STATIC_ASSERT (ALIGNOF (UINT64) =3D=3D sizeof (UINT64), "Alignment= of UINT64 does not > >> >> meet UEFI Specification Data Type requirements"); -#endif STATIC_AS= SERT (ALIGNOF > >> >> (CHAR8) =3D=3D sizeof (CHAR8), "Alignment of CHAR8 does not meet = UEFI Specification Data > >> >> Type requirements"); STATIC_ASSERT (ALIGNOF (CHAR16) =3D=3D sizeof= (CHAR16), "Alignment > >> >> of CHAR16 does not meet UEFI Specification Data Type requirements")= ; STATIC_ASSERT > >> >> (ALIGNOF (INTN) =3D=3D sizeof (INTN), "Alignment of INTN does not m= eet UEFI Specification > >> >> Data Type requirements");=20 > >> > > >> > The commit seems to disturb building process and gets rogue with: > >> > [...] > >> > In file included from /usr/src/sys/contrib/edk2/Include/Uefi/UefiBas= eType.h:16: > >> > /usr/src/sys/contrib/edk2/Include/Base.h:844:16: error: static asser= tion failed due to > >> > requirement '_Alignof(long long) =3D=3D sizeof(long long)': Alignmen= t of INT64 does not > >> > meet UEFI Specification Data Type requirements 844 | STATIC_ASSERT (= ALIGNOF (INT64) > >> > =3D=3D sizeof (INT64), "Alignment of INT64 does not meet UEFI Specif= ication Data Type > >> > requirements"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> > /usr/src/sys/contrib/edk2/Include/Base.h:778:24: note: expanded from= macro 'ALIGNOF' =20 > >> > >> I can't reproduce with the defaults, do you have any loader related > >> build options changed? =20 > > > > Maybe a transient stale rebuild artifact, I was able to get through it > > with -j1 somehow. =20 >=20 > Hmm, after building this a few times I do run into a race condition > where the interpreter isn't done building before loader_ia32.efi. Is > that what you ran into? >=20 > Looks like the SUBDIR entries need to be re-ordered, that's a different > issue from the one above though. >=20 > > =20 > >> Also, can you tell which target this failed on? > >> > >> Thanks. > >> =20 > >> > > >> > > >> > Regards > >> > oh =20 > >> =20 >=20 Architecture is amd64. Most prominent changes/options in /etc/src.conf amongst non-debug flags are= in my case: WITH_BEARSSL=3D YES WITHOUT_LOADER_PXEBOOT=3D YES LOADERSIZE?=3D 555000 WITH_BHYVE_SNAPSHOT=3D YES I had to mess with the loadersize in the past since loader didn't build any= more due to some bytes of space missing ... --=20 A FreeBSD user --Sig_/.qitOwY9QtA6_x.HT94VhD5 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRQheDybVktG5eW/1Kxzvs8OqokrwUCahwG+wAKCRCxzvs8Oqok ryGQAQDohJJrTO62P64HyIrhmrEO8qRftg7mUJrl8VrxnvB2wwD/dgthQJHZOPC8 0IU14h+f70B4MjEVfsHFulu8BkMouwA= =C+pr -----END PGP SIGNATURE----- --Sig_/.qitOwY9QtA6_x.HT94VhD5--