Date: Mon, 1 Nov 2021 22:42:31 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Christian Weisgerber <naddy@mips.inka.de> Cc: Matthias Andree <mandree@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, Piotr Kubaj <pkubaj@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c6c6e67d83c2 - main - audio/flac: don't disable VSX on powerpc64le Message-ID: <YYBfR5RefqxBanK4@KGPE-D16> In-Reply-To: <YYAxxNO7Ws20xoRJ@lorvorc.mips.inka.de> References: <202111010243.1A12hxQj066278@gitrepo.freebsd.org> <YX9ihSk1QxpPn9un@FreeBSD.org> <YX/jekyk152JCnsC@lorvorc.mips.inka.de> <47bc0bef-ca47-d62f-d4a2-e3f4db462fe7@FreeBSD.org> <YYAxxNO7Ws20xoRJ@lorvorc.mips.inka.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--cOgpMPWzutEXizZ9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21-11-01 19:28:20, Christian Weisgerber wrote: > Matthias Andree: >=20 > > > --enable-sse simply adds "-msse2" to the compiler flags. > > >=20 > > > On amd64, this is a nop, since SSE2 is part of the amd64 architecture. > > > On i386, it generates code that won't run on older CPUs that don't > > > support SSE2. > >=20 > > Yeah - do we care? SSE2 has come of age in most legislations :-) >=20 > So has amd64. The only reason to run i386 is on machines that don't > support amd64, e.g. old Soekris [45]xxx and the like. >=20 > Note that flac has assembly optimizations for various SSE levels > that are properly enabled at runtime based on CPUID. You're getting > all that on modern CPUs. On POWER disabling VSX actually disables some code, eg.: https://github.com/xiph/flac/blob/master/src/libFLAC/lpc_intrin_vsx.c#L39 https://github.com/xiph/flac/blob/master/src/libFLAC/include/private/lpc.h#= L94 https://github.com/xiph/flac/blob/master/src/libFLAC/stream_encoder.c#L888 This is a valid reason not to disable VSX if the baseline already includes = VSX (which is the case on powerpc64le). >=20 > --=20 > Christian "naddy" Weisgerber naddy@mips.inka.de --cOgpMPWzutEXizZ9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmGAX0cACgkQelmbhSCD nJ0Usw/+KJ8Wmm+Q+4q5AcEEtaXnN8MR3DOr8sczazvIxDleCR7/jc1REWWu6hkU 3E5iBnXUV+TlbsFbE7qWiyhTj+mK/hJdMMdUPGQc6pJlw+GmmB2hcNbst45YS42N VFV56Tj2QuparqZcM5mP16wpoHVbPthNjMAiyq2DYxrSYXQWV73W3euzJVOVJN7S 6XhtIVmCZLclzPbzqnSdmhrw86LmPc5BpMN+f9azRYkO53FhEYbwWmo757dFjBJj zedoIZ2CVeaYKZ8ZexwYWcp6leBFSLdaNaho3KxUDfAb3pDS83ZM1DwqQ3hx+5KH zMxP/HxKZHkYfHpon7w8bn2+KO0OFdfYUs87rFPnySez/fz8F+rQotGcCi4AxqGr b2g03dC0oIkgrklljFQns/RHHst9u2BlEX7Sz1N0dTBt2OyvPLTeAnGY798W1ByJ rF+BVHPbXVpdE+ErzPhA90erPvAmVFUbn3shyKgWdHlBO30VI7La/Lzo08Pd7A08 U1IONpPBWtFIgdJXKr0kSWCLIZcXrIE+gxmvT/vV0IiNyydT9qzKVuj5MrOgg8Rf V9tmR28V8mTksJKX3odVp2SmfhfXJZkA+AN+LV/rAI9EfG6deym6OIBKlMQqHVmZ Izn9tkrn5BF7H6+IXRM8GgSts/gLwWm0olNzXZoEy/bhQgmqUuM= =nhzd -----END PGP SIGNATURE----- --cOgpMPWzutEXizZ9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YYBfR5RefqxBanK4>